Thanks to visit codestin.com
Credit goes to github.com

Skip to content

bpo-36165 Fix rst formatting for several links in ssl documentation #13133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2019

Conversation

abadger
Copy link
Contributor

@abadger abadger commented May 6, 2019

  • The formatting for ssl.PROTOCOL_SSLv23 and ssl.SSLContext.wrap_bio was
    missing a colon so they weren't properly formatted as links.

  • Corrected link SSLContext.wrap_socket() to be singular instead of plural

Fixes https://bugs.python.org/issue36165

https://bugs.python.org/issue36165

* The formatting for ssl.PROTOCOL_SSLv23 and ssl.SSLContext.wrap_bio was
  missing a colon so they weren't properly formatted as links.

* Corrected link SSLContext.wrap_socket() to be singular instead of plural

Fixes https://bugs.python.org/issue36165
Copy link
Contributor

@lisroach lisroach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lisroach lisroach merged commit 7b3a028 into python:master May 6, 2019
@abadger
Copy link
Contributor Author

abadger commented May 7, 2019

Thanks @lisroach !

@abadger abadger deleted the docs-ssl-formatting branch May 7, 2019 03:43
CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request May 7, 2019
* master: (1204 commits)
  bpo-31855: unittest.mock.mock_open() results now respects the argument of read([size]) (pythonGH-11521)
  Forbid creating of stream objects outside of asyncio (python#13101)
  bpo-35925: Skip SSL tests that fail due to weak external certs. (pythonGH-13124)
  Fix rst formatting for several links in ssl documentation (pythonGH-13133)
  bpo-36542: Allow to overwrite the signature for Python functions. (pythonGH-12705)
  bpo-36793: Remove unneeded __str__ definitions. (pythonGH-13081)
  bpo-36766: Typos in docs and code comments (pythonGH-13116)
  bpo-36275: enhance documentation for venv.create() (pythonGH-13114)
  Clarify the download unit in the download section (pythonGH-13122)
  bpo-30668: add missing word in license.rst (pythonGH-13115)
  Unroll import-team in CODEOWNERS (python#13118)
  bpo-36594: Fix incorrect use of %p in format strings (pythonGH-12769)
  bpo-36798: Updating f-string docs for := use case (pythonGH-13107)
  Update wsgiref.rst (python#10488)
  Doc/c-api/exceptions.rst: fix grammar (python#12091)
  bpo-36811: Fix a C compiler warning in _elementtree.c. (pythonGH-13109)
  Only count number of members once (python#12691)
  bpo-16024: Doc cleanup regarding path_fd, dir_fd, follow_symlinks (pythonGH-5505)
  bpo-36791: Safer detection of integer overflow in sum(). (pythonGH-13080)
  bpo-33530: Implement Happy Eyeballs in asyncio, v2 (pythonGH-7237)
  ...
@miss-islington
Copy link
Contributor

Thanks @abadger for the PR, and @lisroach for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @abadger for the PR, and @lisroach for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @abadger and @lisroach, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 7b3a028c357dcc76b5aff7297e7c8052f897afb5 3.8

@bedevere-bot
Copy link

GH-14281 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 21, 2019
@miss-islington
Copy link
Contributor

Thanks @abadger for the PR, and @lisroach for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @abadger and @lisroach, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 7b3a028c357dcc76b5aff7297e7c8052f897afb5 3.8

miss-islington added a commit that referenced this pull request Jun 21, 2019
(cherry picked from commit 7b3a028)

Co-authored-by: Toshio Kuratomi <[email protected]>
abadger added a commit to abadger/cpython that referenced this pull request Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants