Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[3.13] gh-131277: allow EnvironmentVarGuard to unset more than one environment variable at once (GH-131280) #131409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

picnixz
Copy link
Member

@picnixz picnixz commented Mar 18, 2025

(cherry picked from commit 3185e31)

Co-authored-by: Hugo van Kemenade [email protected]

@picnixz picnixz requested review from hugovk, barneygale and a team as code owners March 18, 2025 12:18
@picnixz picnixz marked this pull request as draft March 18, 2025 12:23
@picnixz picnixz changed the title [3.13] gh-131277: allow EnvironmentVarGuard to unset more than one environment variable at once (GH-131280) [3.13] gh-131277: allow EnvironmentVarGuard to unset more than one environment variable at once (GH-131280) Mar 18, 2025
@picnixz picnixz marked this pull request as ready for review March 18, 2025 12:29
@picnixz
Copy link
Member Author

picnixz commented Mar 18, 2025

Note: some usages were removed from the original commit because the existing code did not use EnvironmentVarGuard at all. Since I didn't want to refactor all the tests, I kept the original code.

@picnixz picnixz merged commit 85c2037 into python:3.13 Mar 18, 2025
40 checks passed
@picnixz picnixz deleted the bp-313/3185e3115c918ec189e16cf9f5b51a13a0146556/unset-env-var-131280 branch March 18, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant