Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-130655: Add a test for bad magic numbers when parsing gettext MO files #131909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
picnixz merged 4 commits into from
Apr 4, 2025
Merged

gh-130655: Add a test for bad magic numbers when parsing gettext MO files #131909

picnixz merged 4 commits into from
Apr 4, 2025

Conversation

@tomasr8
Copy link
Member

@tomasr8 tomasr8 commented Mar 30, 2025 •
edited by bedevere-app bot
Loading

We're currently not testing that MO files with invalid magic numbers are properly rejected. This PR adds a test for it.

@bedevere-app bedevere-app bot added tests Tests in the Lib/test dir awaiting review labels Mar 30, 2025
@bedevere-app bedevere-app bot mentioned this pull request Mar 30, 2025
Open
@tomasr8 tomasr8 added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Mar 30, 2025
picnixz
picnixz approved these changes Mar 30, 2025
View reviewed changes
@tomasr8 tomasr8 requested a review from picnixz April 2, 2025 12:09
@picnixz picnixz enabled auto-merge (squash) April 4, 2025 13:03
@picnixz picnixz merged commit 16a6270 into python:main Apr 4, 2025
38 checks passed
@miss-islington-app
Copy link

miss-islington-app bot commented Apr 4, 2025

Thanks @tomasr8 for the PR, and @picnixz for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 4, 2025
@tomasr8 @miss-islington
pythongh-130655: Add a test for bad magic numbers in .mo files pars…
0c0fd11 
…ed by `gettext` (pythonGH-131909)

(cherry picked from commit 16a6270)

Co-authored-by: Tomas R. <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 4, 2025
@tomasr8 @miss-islington
pythongh-130655: Add a test for bad magic numbers in .mo files pars…
001fe0f 
…ed by `gettext` (pythonGH-131909)

(cherry picked from commit 16a6270)

Co-authored-by: Tomas R. <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Apr 4, 2025

GH-132077 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Apr 4, 2025
@bedevere-app
Copy link

bedevere-app bot commented Apr 4, 2025

GH-132078 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Apr 4, 2025
@tomasr8 tomasr8 deleted the gettext-magic branch April 4, 2025 13:52
picnixz pushed a commit that referenced this pull request Apr 4, 2025
@miss-islington @tomasr8
[3.13] gh-130655: Add a test for bad magic numbers in .mo files par…
2c05ebd 
…sed by `gettext` (GH-131909) (#132077)

gh-130655: Add a test for bad magic numbers in `.mo` files parsed by `gettext` (GH-131909)
(cherry picked from commit 16a6270)

Co-authored-by: Tomas R <[email protected]>
picnixz pushed a commit that referenced this pull request Apr 4, 2025
@miss-islington @tomasr8
[3.12] gh-130655: Add a test for bad magic numbers in .mo files par…
232e105 
…sed by `gettext` (GH-131909) (#132078)

gh-130655: Add a test for bad magic numbers in `.mo` files parsed by `gettext` (GH-131909)
(cherry picked from commit 16a6270)

Co-authored-by: Tomas R <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz picnixz approved these changes

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tomasr8 @picnixz