Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-121468: Support async breakpoint in pdb #132576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gaogaotiantian merged 13 commits into from
Apr 29, 2025
Merged

gh-121468: Support async breakpoint in pdb #132576

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
1b77cdb
Add set_trace_async for async support
gaogaotiantian Apr 13, 2025
285efe2
Merge branch 'main' into support-async-breakpoint
gaogaotiantian Apr 16, 2025
677c952
Update docs
gaogaotiantian Apr 16, 2025
15290d5
📜🤖 Added by blurb_it.
blurb-it[bot] Apr 16, 2025
a3401e9
reorder the if checks
gaogaotiantian Apr 16, 2025
50c3c9c
Add breakpoint tests
gaogaotiantian Apr 16, 2025
a6c580d
Merge branch 'main' into support-async-breakpoint
gaogaotiantian Apr 16, 2025
090715b
Update test
gaogaotiantian Apr 16, 2025
ebdc161
Add whatsnew entry
gaogaotiantian Apr 16, 2025
109d8b1
Restructure default function
gaogaotiantian Apr 22, 2025
e953532
Add context var tests
gaogaotiantian Apr 22, 2025
968472d
Merge branch 'main' into support-async-breakpoint
gaogaotiantian Apr 25, 2025
ff09ab2
Add an extra check for get_var()
gaogaotiantian Apr 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
reorder the if checks
  • Loading branch information
@gaogaotiantian
gaogaotiantian committed Apr 16, 2025
commit a3401e92754c148abd956f619d9829bc98a5c748
4 changes: 2 additions & 2 deletions Lib/pdb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -891,9 +891,9 @@ def default(self, line):
except Exception as e:
Comment thread
gaogaotiantian marked this conversation as resolved.
Outdated
# Maybe it's an await expression/statement
if (
isinstance(e, SyntaxError)
self.async_shim_frame is not None
and isinstance(e, SyntaxError)
and e.msg == "'await' outside function"
and self.async_shim_frame is not None
):
try:
self._exec_await(buffer, globals, locals)
Copy link
Copy Markdown
Contributor

@graingert graingert Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be run without the exception from line 891 in the context

Copy link
Copy Markdown
Member Author

@gaogaotiantian gaogaotiantian Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I restructured the code as we know whether it is an await code during compile. The nice side effect is that we don't need to execute the code under the exception context.

Expand Down