Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-117088: Fix AIX build #132595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 10, 2025
Merged

gh-117088: Fix AIX build #132595

merged 2 commits into from
May 10, 2025

Conversation

ayappanec
Copy link
Contributor

@ayappanec ayappanec commented Apr 16, 2025 •
edited by bedevere-app bot
Loading

This PR is to fix the problem mentioned in the issue #117088

@bedevere-app bedevere-app bot mentioned this pull request Apr 16, 2025
Closed
@serhiy-storchaka
Copy link
Member

Does it support -soname= or something like? That option was originally used to fix #38147, so I wonder whether removing it may reintroduce a bug.

@ayappanec
Copy link
Contributor Author

Does it support -soname= or something like? That option was originally used to fix #38147, so I wonder whether removing it may reintroduce a bug.

AIX linker don't have support for "-soname" or any such equivalent. I don't think AIX was affected by #38147 for the same reason like solaris (as mentioned in that thread).

serhiy-storchaka
serhiy-storchaka approved these changes Apr 17, 2025
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@serhiy-storchaka serhiy-storchaka merged commit 47f1722 into python:main May 10, 2025
41 checks passed
@serhiy-storchaka serhiy-storchaka added the needs backport to 3.14 bugs and security fixes label May 10, 2025
@miss-islington-app
Copy link

Thanks @ayappanec for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 10, 2025
@ayappanec @miss-islington
pythongh-117088: Fix AIX build (pythonGH-132595)
f6fdb36 
(cherry picked from commit 47f1722)

Co-authored-by: Ayappan Perumal <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented May 10, 2025

GH-133838 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label May 10, 2025
@serhiy-storchaka serhiy-storchaka added the needs backport to 3.13 bugs and security fixes label May 10, 2025
@miss-islington-app
Copy link

Thanks @ayappanec for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 10, 2025
@ayappanec @miss-islington
pythongh-117088: Fix AIX build (pythonGH-132595)
cde6f41 
(cherry picked from commit 47f1722)

Co-authored-by: Ayappan Perumal <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented May 10, 2025

GH-133839 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 10, 2025
serhiy-storchaka pushed a commit that referenced this pull request May 10, 2025
@miss-islington @ayappanec
[3.13] gh-117088: Fix AIX build (GH-132595) (GH-133839)
5afb224 
(cherry picked from commit 47f1722)

Co-authored-by: Ayappan Perumal <[email protected]>
serhiy-storchaka pushed a commit that referenced this pull request May 10, 2025
@miss-islington @ayappanec
[3.14] gh-117088: Fix AIX build (GH-132595) (GH-133838)
6dc12da 
(cherry picked from commit 47f1722)

Co-authored-by: Ayappan Perumal <[email protected]>
@ayappanec
Copy link
Contributor Author

@serhiy-storchaka Thanks for the merge.

@serhiy-storchaka
Copy link
Member

You are welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ayappanec @serhiy-storchaka