Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-131798: JIT: Split CALL_TUPLE_1 into several uops #132851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brandtbucher merged 6 commits into from
Apr 24, 2025
Merged

gh-131798: JIT: Split CALL_TUPLE_1 into several uops #132851

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a494d3e
Split up _CALL_TUPLE_1
tomasr8 Apr 12, 2025
c657bb3
Add news entry
tomasr8 Apr 23, 2025
0545930
Optimize case when input is already a tuple
tomasr8 Apr 24, 2025
1a75e53
unused2 -> unused
tomasr8 Apr 24, 2025
7e7c13e
Merge remote-tracking branch 'upstream/main' into jit-call-tuple-1
tomasr8 Apr 24, 2025
2023556
Regen
tomasr8 Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Regen
  • Loading branch information
@tomasr8
tomasr8 committed Apr 24, 2025
commit 2023556ad21e584efb5e9aeb10c2c838343c1a4b
2 changes: 1 addition & 1 deletion Include/internal/pycore_opcode_metadata.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

281 changes: 141 additions & 140 deletions Include/internal/pycore_uop_ids.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion Include/internal/pycore_uop_metadata.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Lib/test/test_capi/test_opt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1898,7 +1898,7 @@ def testfunc(n):
for _ in range(n):
y = tuple((1, 2)) # tuple argument
a, _ = y # _UNPACK_SEQUENCE_TWO_TUPLE
Copy link
Copy Markdown
Member Author

@tomasr8 tomasr8 Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I needed to use UNPACK_SEQUENCE(_TWO)_TUPLE here since it is currently the only uop that propagates the tuple items to the result.

Copy link
Copy Markdown
Member

@brandtbucher brandtbucher Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice observation. Seems like _BINARY_OP_SUBSCR_TUPLE_INT could be taught how to do this pretty easily for a constant RHS. Want to add that to your queue?

Copy link
Copy Markdown
Member Author

@tomasr8 tomasr8 Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's already in the queue 😄

if a == 1: # _COMPARE_OP_INT + _GUARD_IS_TRUE_POP are removed
if a == 1: # _COMPARE_OP_INT + _GUARD_IS_TRUE_POP are removed
x += 1
return x

Expand Down
Loading