Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-133036: Deprecate codecs.open #133038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
methane merged 9 commits into from
Apr 30, 2025
Merged

gh-133036: Deprecate codecs.open #133038

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
655759b
gh-133036: deprecate codecs.open
methane Apr 27, 2025
47ebf4f
codecs_open_nowarn -> codecs_open_no_warn
methane Apr 28, 2025
ff0d25d
fix tests
methane Apr 28, 2025
cba4e03
remove codecs.open from error message
methane Apr 28, 2025
c2a52e3
fix windows test
methane Apr 28, 2025
744eff0
add pending-removal-in-future entry
methane Apr 29, 2025
b2dced5
Apply suggestions from code review
methane Apr 29, 2025
c8af536
Update Doc/deprecations/pending-removal-in-future.rst
methane Apr 29, 2025
ce5c94b
Update Lib/test/test_codecs.py
methane Apr 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix tests
  • Loading branch information
@methane
methane committed Apr 28, 2025
commit ff0d25d9d14c4a476fd44d41b05d7545eead88fe
3 changes: 2 additions & 1 deletion Lib/test/test_multibytecodec.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,8 @@ def test_bug1728403(self):
f.write(b'\xa1')
finally:
f.close()
f = codecs.open(TESTFN, encoding='cp949')
with self.assertWarns(DeprecationWarning):
f = codecs.open(TESTFN, encoding='cp949')
try:
self.assertRaises(UnicodeDecodeError, f.read, 2)
finally:
Expand Down
6 changes: 3 additions & 3 deletions Lib/test/test_sax.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
# regression test for SAX 2.0
# $Id$

from xml.sax import make_parser, ContentHandler, \
SAXException, SAXReaderNotAvailable, SAXParseException
Expand Down Expand Up @@ -832,8 +831,9 @@ class StreamReaderWriterXmlgenTest(XmlgenTest, unittest.TestCase):
fname = os_helper.TESTFN + '-codecs'

def ioclass(self):
writer = codecs.open(self.fname, 'w', encoding='ascii',
errors='xmlcharrefreplace', buffering=0)
with self.assertWarns(DeprecationWarning):
writer = codecs.open(self.fname, 'w', encoding='ascii',
errors='xmlcharrefreplace', buffering=0)
def cleanup():
writer.close()
os_helper.unlink(self.fname)
Expand Down
Loading