gh-133146: Add the old public get_value method to documentation and refactor code.
#133301
+21
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get_value method to documantation and refactor code.get_value method to documantation and refactor code.
get_value method to documantation and refactor code.get_value method to documentation and refactor code.
YvesDup
commented
May 3, 2025
Comment on lines
+138
to
+142
| '''Returns current value of Semaphore. | ||
|
|
||
| Raises NotImplementedError on Mac OSX | ||
| because of broken sem_getvalue(). | ||
| ''' |
There was a problem hiding this comment.
This file has no docstring. Should we remove this one ?
|
Why is this method is undocumented ? Updated: I only suggest to refactor code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
multiprocessing.Lockclass._semlockattribute ofmultiprocessing.Sempahoreclass.The
multiprocessing.BoundedSempahore,multiprocessing.Conditionandmultiprocessing.Queueclasses will update.multiprocessing.[Bounded]Semaphore.get_valuemethod and refactor code #133146📚 Documentation preview 📚: https://cpython-previews--133301.org.readthedocs.build/