gh-133102: Remove unnecessary mention of os.fsync() from os.exec*() docs #133333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before a process is replaced by os.exec*(), userspace buffers usually need to be flushed. However, it is not necessary to flush kernel buffers to disk using os.fsync(). Flushing userspace buffer to kernel, and flushing kernel buffer to disk, are two different things. In addition, os.fsync() is not applicable to pipes or sockets. This patch removes this confusing information.
|
All commit authors signed the Contributor License Agreement. |
Co-authored-by: Peter Bierma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before a process is replaced by os.exec*(), userspace buffers usually need to be flushed. However, it is not necessary to flush kernel buffers to disk using os.fsync(). Flushing userspace buffer to kernel, and flushing kernel buffer to disk, are two different things. In addition, os.fsync() is not applicable to pipes or sockets. This patch removes this confusing information.
📚 Documentation preview 📚: https://cpython-previews--133333.org.readthedocs.build/