Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix typos in documentation. Patch by tirkarthi. #13354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2019
Merged

Fix typos in documentation. Patch by tirkarthi. #13354

merged 1 commit into from
May 16, 2019

Conversation

terryjreedy
Copy link
Member

No description provided.

@terryjreedy terryjreedy self-assigned this May 16, 2019
@terryjreedy terryjreedy mentioned this pull request May 16, 2019
Merged
tirkarthi
tirkarthi approved these changes May 16, 2019
View reviewed changes
Copy link
Member

@tirkarthi tirkarthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@terryjreedy terryjreedy merged commit 8a533ff into python:master May 16, 2019
@miss-islington
Copy link
Contributor

Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 16, 2019
@terryjreedy @miss-islington
Fix typos in documentation. Patch by tirkarthi. (pythonGH-13354)
4493568 
(cherry picked from commit 8a533ff)

Co-authored-by: Terry Jan Reedy <[email protected]>
@bedevere-bot
Copy link

GH-13356 is a backport of this pull request to the 3.7 branch.

@terryjreedy terryjreedy deleted the fix-typo branch May 16, 2019 05:21
@terryjreedy
Copy link
Member Author

Somehow my working file did not have the 'millesecond' => 'millisecond' correction someone did about a month ago, even though everything was supposed to be up to date.

miss-islington added a commit that referenced this pull request May 16, 2019
@miss-islington @terryjreedy
Fix typos in documentation. Patch by tirkarthi. (GH-13354)
876756e 
(cherry picked from commit 8a533ff)

Co-authored-by: Terry Jan Reedy <[email protected]>
@tirkarthi
Copy link
Member

I think this was missed in #13116 though my report had it as an item for idle.rst : https://bugs.python.org/issue36766#msg341194

@terryjreedy
Copy link
Member Author

terryjreedy commented May 16, 2019 •
edited
Loading

You message specified help.html rather than idle.rst, and there is what got edited. I should have noticed. help.html should not be directly edited since it is a generated file -- a trailing whitespace trimmed copy of the file generated from idle.rst by Sphinx. So when I generated it the first time today, I noticed the reversion and added the change to idle.rst. This clears up why is was only needed there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tirkarthi tirkarthi tirkarthi approved these changes

Assignees

@terryjreedy terryjreedy

Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@terryjreedy @miss-islington @bedevere-bot @tirkarthi @the-knights-who-say-ni