gh-132558: add convert_choices parameter to add_argument
#133826
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3bca80f to
7fb5415
Compare
This will allow better error messages.
7fb5415 to
afaa8ab
Compare
afaa8ab to
b1be432
Compare
|
As I mentioned before, I don't think we should do this. I think we should aim improve the documentation since this will scale better. I will review that PR next. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an optional argument to
convert_choicesto theadd_argumentfunction. This allows users to specify both atypeandchoicesand will ensure the choices are converted by thetypecallable before checking. This improvesusage,helpanderrormessages for the end-user.choiceswithtype#132558📚 Documentation preview 📚: https://cpython-previews--133826.org.readthedocs.build/