-
-
Notifications
You must be signed in to change notification settings - Fork 32k
Exclude include in reference/grammar.rst
in gettext builds
#133868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This will exclude any other formats -- |
I tried not gettext and it did not work unfortunately. (Previous commit) |
Is it because |
|
The |
|
That's odd, it must be bugged then, not gettext did not work. |
I second to that. The grammar contains many comments, which definitely would be helpful if translated. In my opinion we should split the grammar include for gettext builder by every double newline character. This could be controlled as an option in the |
IMO even if we do it should not be prioritised. If someone is reading the grammar, they should probably know English. There are a few hundred lines, we wonβt translate error messages or var names anyway, is there really a point? |
I see it being similar to code snippets β we should translate only comments here. As we don't have a way to parse what's comment and what's not, to allow the comments translation we should allow translation of the whole grammar content. I agree it's not a priority from whole translation perspective. |
Note that many comments here mention features that this version of the Grammar omits. IMO, we should copy any relevant comments to the preceding note, or preceding chapters (many of them are already there!), and then remove the comments altogether. |
The include is too big (one string) and translations leave it untranslated.
π Documentation preview π: https://cpython-previews--133868.org.readthedocs.build/