Improve tests for str to Fraction conversion #134010
Conversation
| self.assertEqual((3, 2), _components(F("3/2"))) | ||
| self.assertEqual((3, 2), _components(F("3 / 2"))) | ||
| self.assertEqual((3, 2), _components(F(" \n +3/2"))) | ||
| self.assertEqual((-3, 2), _components(F("-3/2 "))) | ||
| self.assertEqual((13, 2), _components(F(" 013/02 \n "))) | ||
| self.assertEqual((13, 2), _components(F(" 0013/002 \n "))) |
There was a problem hiding this comment.
Why this was replaced, not added?
There was a problem hiding this comment.
It is virtually the same test, but tests that more than one zero is accepted. There were no tests for leading zero in other forms, so they were added.
| def check_invalid(s): | ||
| msg = "Invalid literal for Fraction: " + repr(s) | ||
| self.assertRaisesMessage(ValueError, msg, F, s) |
There was a problem hiding this comment.
This looks fine.
But maybe use subTest?
for value in ["3/", "/2", # there can be a lot of...
# Denominators don't need a sign.
"3/+2", "3/-2",
# Imitate float's parsing.
...]:
with self.subTest(value=value):
check_invalid(value)There was a problem hiding this comment.
The main reason is that if we make error messages more specific, it is easier to add an optional parameter, while keeping default for most tests. For example, I originally planned to add the tests here that are currently in test_limit_int.
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
(cherry picked from commit 17d0fec) Co-authored-by: Serhiy Storchaka <[email protected]>
(cherry picked from commit 17d0fec) Co-authored-by: Serhiy Storchaka <[email protected]>
|
GH-134016 is a backport of this pull request to the 3.14 branch. |
|
GH-134017 is a backport of this pull request to the 3.13 branch. |
…34017) (cherry picked from commit 17d0fec) Co-authored-by: Serhiy Storchaka <[email protected]>
…34016) (cherry picked from commit 17d0fec) Co-authored-by: Serhiy Storchaka <[email protected]>
No description provided.