Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Test also error messages in test_limit_int. #134018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025

Conversation

serhiy-storchaka
Copy link
Member

I forgot to push this change in #134010. 🤦

@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir skip issue skip news labels May 14, 2025
@serhiy-storchaka serhiy-storchaka enabled auto-merge (squash) May 14, 2025 17:26
@serhiy-storchaka serhiy-storchaka merged commit e123a1d into python:main May 14, 2025
46 checks passed
@serhiy-storchaka serhiy-storchaka added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels May 15, 2025
@miss-islington-app
Copy link

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 15, 2025
(cherry picked from commit e123a1d)

Co-authored-by: Serhiy Storchaka <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 15, 2025
(cherry picked from commit e123a1d)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented May 15, 2025

GH-134032 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 15, 2025
@bedevere-app
Copy link

bedevere-app bot commented May 15, 2025

GH-134033 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label May 15, 2025
@serhiy-storchaka serhiy-storchaka deleted the testFromString branch May 15, 2025 07:20
serhiy-storchaka added a commit that referenced this pull request May 15, 2025
serhiy-storchaka added a commit that referenced this pull request May 15, 2025
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot wasm32-wasi 3.14 (tier-2) has failed when building commit fede4ed.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1745/builds/73) and take a look at the build logs.
  4. Check if the failure is related to this commit (fede4ed) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1745/builds/73

Failed tests:

  • test_zipfile

Failed subtests:

  • test_write_without_source_date_epoch - test.test_zipfile.test_core.OtherTests.test_write_without_source_date_epoch

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
  File "/Lib/test/test_zipfile/test_core.py", line 1832, in test_write_without_source_date_epoch
    self.assertAlmostEqual(z_time, c_time, delta=1)
    ~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 4 != 6 within 1 delta (2 difference)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip issue skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants