gh-118234: Avoid socket failure with missing SYSTEMROOT env var on Windows #134363
Conversation
Resolves python#118234 by checking for the SystemRoot environment variable and, if it is missing, setting it based on GetWindowsDirectoryW. As described in the issue, the default path of the provider DLL is stored in the registry as "%SystemRoot%\System32\mswsock.dll" which does not resolve without SystemRoot set (typically to "C:\Windows").
|
I don't think that it's a good idea to set cc @zooba |
|
Yeah, I don't love this, and certainly not as part of socketmodule. It might make sense in python.c, to detect whenever someone launches Python with an empty environment, but it's probably even better in subprocess to warn people before they launch with an empty environment. In my experience, this only ever happens when launching from Python. I've not seen any other language cause it. This list linked in the bug has the main ones, and we should probably just ensure that subprocess always sets them if the caller omits them. |
|
Sent gh-134435 instead. |
Resolves #118234 by checking for the SystemRoot environment variable and, if it is missing, setting it based on
GetWindowsDirectoryW.As described in the issue, the default path of the provider DLL is stored in the registry as "%SystemRoot%\System32\mswsock.dll" which does not resolve without SystemRoot set (typically to "C:\Windows").