gh-134262: increase retries in Tools/build/generate_sbom.py
#134558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Increase max retry count to 7 - Increase base of exponential backoff to 2.25 - Add jitter in case there is some issue with sending requests at the same time - Also print the location that fails
Tools/build/generate_sbom.py
|
Thanks @emmatyping for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
|
Sorry, @emmatyping and @hugovk, I could not cleanly backport this to |
|
Sorry, @emmatyping and @hugovk, I could not cleanly backport this to |
|
Does this still need backporting? |
|
Ideally probably. I can try to do that tomorrow. |
emmatyping
added a commit
to emmatyping/cpython
that referenced
this pull request
Jun 17, 2025
…m.py` (pythonGH-134558) (cherry picked from commit 3f9eb55) Co-authored-by: Emma Smith <[email protected]>
|
GH-135596 is a backport of this pull request to the 3.14 branch. |
|
The retries aren't in the 3.13 branch, so I only made changes for 3.14. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The retry backoff now ranges from 1 second to 130 seconds.