Update outdated statement from math about C standard
#134621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skirpichev
reviewed
May 24, 2025
There was a problem hiding this comment.
“This module provides access to the mathematical functions defined by the C standard.”
Obviously, -1 to that.
There is nothing wrong with this sentence - the module does provide access to such functions (at least for most of them). Edit: It's just not exhaustive description of the module content.
picnixz
reviewed
May 24, 2025
math about C standardmath about C standard
picnixz
approved these changes
May 27, 2025
AA-Turner
approved these changes
May 28, 2025
|
Thanks @hugovk for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 28, 2025
(cherry picked from commit 21672b6) Co-authored-by: Hugo van Kemenade <[email protected]> Co-authored-by: Adam Turner <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 28, 2025
(cherry picked from commit 21672b6) Co-authored-by: Hugo van Kemenade <[email protected]> Co-authored-by: Adam Turner <[email protected]>
|
GH-134825 is a backport of this pull request to the 3.14 branch. |
|
GH-134826 is a backport of this pull request to the 3.13 branch. |
AA-Turner
added a commit
that referenced
this pull request
May 28, 2025
) (#134826) Update outdated statement from `math` about C standard (GH-134621) (cherry picked from commit 21672b6) Co-authored-by: Hugo van Kemenade <[email protected]> Co-authored-by: Adam Turner <[email protected]>
AA-Turner
added a commit
that referenced
this pull request
May 28, 2025
) (#134825) Update outdated statement from `math` about C standard (GH-134621) (cherry picked from commit 21672b6) Co-authored-by: Hugo van Kemenade <[email protected]> Co-authored-by: Adam Turner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PEP 791 draft says:
Let's start by removing this outdated sentence from the docs.
📚 Documentation preview 📚: https://cpython-previews--134621.org.readthedocs.build/