Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-134635: add zlib.{adler32,crc32}_combine to combine checksums #134650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
May 27, 2025
Merged

gh-134635: add zlib.{adler32,crc32}_combine to combine checksums #134650

merged 10 commits into from
May 27, 2025

Conversation

picnixz
Copy link
Member

@picnixz picnixz commented May 25, 2025 •
edited by github-actions bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request May 25, 2025
Closed
@picnixz picnixz requested a review from emmatyping May 25, 2025 12:38
picnixz
picnixz commented May 25, 2025
View reviewed changes
emmatyping
emmatyping reviewed May 25, 2025
View reviewed changes
Copy link
Member

@emmatyping emmatyping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a few suggestions/thoughts but overall looks great!

@picnixz
Copy link
Member Author

picnixz commented May 25, 2025

Thanks for the feedback! I'm not on my dev session so I won't be able to change the clinic-related code as I'll need to regen the files, but I'll address the rest in the meantime.

thatch
thatch reviewed May 26, 2025
View reviewed changes
thatch
thatch reviewed May 26, 2025
View reviewed changes
thatch
thatch approved these changes May 26, 2025
View reviewed changes
Copy link
Contributor

@thatch thatch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, thanks!

@picnixz picnixz force-pushed the feat/zlib/crc32-combine-134635 branch from aa8b941 to c5a2c55 Compare May 26, 2025 09:03
@picnixz
Copy link
Member Author

picnixz commented May 26, 2025

Thanks for the reviews both of you!

@picnixz picnixz requested review from emmatyping and thatch May 26, 2025 09:25
emmatyping
emmatyping approved these changes May 26, 2025
View reviewed changes
Copy link
Member

@emmatyping emmatyping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two suggestions for wording but otherwise looks great! Thank you for adding these.

picnixz
picnixz commented May 26, 2025
View reviewed changes
Copy link
Member Author

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've edited your suggestion a bit but thank you!

@picnixz picnixz self-assigned this May 26, 2025
@picnixz picnixz merged commit 737b4ba into python:main May 27, 2025
39 checks passed
@picnixz picnixz deleted the feat/zlib/crc32-combine-134635 branch May 27, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmatyping emmatyping emmatyping approved these changes

@thatch thatch thatch approved these changes

Assignees

@picnixz picnixz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@picnixz @thatch @emmatyping