-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
gh-134861: Add CSV and 🍌SV output formats to asyncio ps
#134862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dpdani
wants to merge
8
commits into
python:main
Choose a base branch
from
dpdani:feature/pending-tasks-csv-bsv
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
cf70073
Add CSV and 🍌SV output formats to `asyncio ps`
dpdani 75d0b14
Merge branch 'main' into feature/pending-tasks-csv-bsv
dpdani 4b77995
Update Lib/asyncio/tools.py
dpdani f5132c9
Move table output to separate function
dpdani cd11ad7
📜🤖 Added by blurb_it.
blurb-it[bot] 21b581a
explain why 🍌s are relevant
dpdani e44226d
make it a secret 🤫
dpdani fe3cf6c
Merge branch 'main' into feature/pending-tasks-csv-bsv
dpdani File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,6 +5,8 @@ | |
from enum import Enum | ||
import sys | ||
from _remote_debugging import RemoteUnwinder, FrameInfo | ||
import csv | ||
|
||
|
||
class NodeType(Enum): | ||
COROUTINE = 1 | ||
|
@@ -232,20 +234,56 @@ def _get_awaited_by_tasks(pid: int) -> list: | |
sys.exit(1) | ||
|
||
|
||
def display_awaited_by_tasks_table(pid: int) -> None: | ||
class TaskTableOutputFormat(Enum): | ||
table = "table" | ||
csv = "csv" | ||
bsv = "bsv" | ||
# As per the words of the asyncio 🍌SV spec lead: | ||
# > 🍌SV is not just a format. It’s a lifestyle. A philosophy. | ||
# https://www.youtube.com/watch?v=RrsVi1P6n0w | ||
|
||
|
||
_header = ('tid', 'task id', 'task name', 'coroutine stack', 'awaiter chain', 'awaiter name', 'awaiter id') | ||
|
||
|
||
def display_awaited_by_tasks_table( | ||
pid: int, | ||
format_: TaskTableOutputFormat | str = TaskTableOutputFormat.table | ||
) -> None: | ||
"""Build and print a table of all pending tasks under `pid`.""" | ||
|
||
tasks = _get_awaited_by_tasks(pid) | ||
table = build_task_table(tasks) | ||
format_ = TaskTableOutputFormat(format_) | ||
if format_ == TaskTableOutputFormat.table: | ||
_display_awaited_by_tasks_table(table) | ||
else: | ||
_display_awaited_by_tasks_csv(table, format_) | ||
|
||
|
||
def _display_awaited_by_tasks_table(table) -> None: | ||
# Print the table in a simple tabular format | ||
print( | ||
f"{'tid':<10} {'task id':<20} {'task name':<20} {'coroutine stack':<50} {'awaiter chain':<50} {'awaiter name':<15} {'awaiter id':<15}" | ||
f"{_header[0]:<10} {_header[1]:<20} {_header[2]:<20} {_header[3]:<50} {_header[4]:<50} {_header[5]:<15} {_header[6]:<15}" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Try storing the numbers in either another array or a tulle with headers and for loop this print. |
||
) | ||
print("-" * 180) | ||
for row in table: | ||
print(f"{row[0]:<10} {row[1]:<20} {row[2]:<20} {row[3]:<50} {row[4]:<50} {row[5]:<15} {row[6]:<15}") | ||
|
||
|
||
def _display_awaited_by_tasks_csv(table, format_: TaskTableOutputFormat) -> None: | ||
match format_: | ||
case TaskTableOutputFormat.csv: | ||
delimiter = ',' | ||
case TaskTableOutputFormat.bsv: | ||
delimiter = '\N{BANANA}' | ||
case _: | ||
raise ValueError(f"Unknown output format: {format_}") | ||
csv_writer = csv.writer(sys.stdout, delimiter=delimiter) | ||
csv_writer.writerow(_header) | ||
csv_writer.writerows(table) | ||
|
||
|
||
def display_awaited_by_tasks_tree(pid: int) -> None: | ||
"""Build and print a tree of all pending tasks under `pid`.""" | ||
|
||
|
3 changes: 3 additions & 0 deletions
3
Misc/NEWS.d/next/Library/2025-05-29-19-00-37.gh-issue-134861.y2-fu-.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
Add CSV output format to asyncio ps | ||
|
||
Absolutely no other output format was added in this PR 🍌 |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.