Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-134895: Add sphinx-codeautolink to doc build #134896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cmarqu
Copy link
Contributor

@cmarqu cmarqu commented May 29, 2025

This PR adds the https://sphinx-codeautolink.readthedocs.io/ Sphinx extension to the documentation build process. In their own words, it

makes code examples clickable by inserting links from individual code elements to the corresponding reference documentation

In my opinion, it is quite helpful for documentation readers to be able to immediately jump from e.g. tutorial code using logging.getLogger (<-- points to the PR doc build that shows the linking) to its reference description.

A bit of discussion has happened in https://discuss.python.org/t/add-the-sphinx-codeautolink-extension-to-doc-build-process/80814, back when the extension was not as robust and featureful as nowadays.
As said there, the styling of these extra links can be as unobtrusive as we want them.

Code examples that are parseable and self-contained (i.e. have all their imports) will have clickable objects.

Examples that are made up of parts that build on each other can also be supported with some extra markup (not part of this PR).
Missing imports can be annotated "invisibly" (not part of this PR).

Also, in the current state of the documentation, not all code examples that could be parseable actually are.
#133906 would fix a number of these.

Other examples would benefit from using .. code-block:: with an explicit language set instead of :: so that special handling for pycon (clean_pycon) could kick in. Right now, these places are producing a warning that is handled via suppress_warnings.

Speaking of suppress_warnings, it contains config.cache because of
WARNING: cannot cache unpickleable configuration value: 'codeautolink_custom_blocks' (because it contains a function, class, or module object) [config.cache], which is indeed set to the function clean_pycon.


📚 Documentation preview 📚: https://cpython-previews--134896.org.readthedocs.build/

@StanFromIreland
Copy link
Member

Is it possible for the text to not be underlined, it seems quite weird now for code examples to have link style highlighting:

image

@cmarqu
Copy link
Contributor Author

cmarqu commented May 29, 2025

@StanFromIreland It is absolutely possible to style the links in any way we want, but for reviewing the effect of the extension (i.e., what it links and what it doesn't), it is helpful to have styling where the links stand out.

I'll amend the styling in this PR after more comments have come in.

@cmarqu
Copy link
Contributor Author

cmarqu commented May 30, 2025

I also have an old all-in-one branch around that fixes most of the warnings in the ReST sources: main...cmarqu:cpython:feat/add-sphinx-codeautolink; to get a feeling of what that would entail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants