-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
gh-134733: Fix documentation for the show_empty option of ast.dump() #134925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
serhiy-storchaka
merged 2 commits into
python:main
from
serhiy-storchaka:ast-dump-show-empty-docs
May 30, 2025
Merged
gh-134733: Fix documentation for the show_empty option of ast.dump() #134925
serhiy-storchaka
merged 2 commits into
python:main
from
serhiy-storchaka:ast-dump-show-empty-docs
May 30, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ump() Optional None values are always omitted.
sharktide
reviewed
May 30, 2025
JelleZijlstra
approved these changes
May 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, left an optional wording suggestion
Co-authored-by: Jelle Zijlstra <[email protected]>
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 30, 2025
…ump() (pythonGH-134925) Optional None values are always omitted. (cherry picked from commit 1a89991) Co-authored-by: Serhiy Storchaka <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 30, 2025
…ump() (pythonGH-134925) Optional None values are always omitted. (cherry picked from commit 1a89991) Co-authored-by: Serhiy Storchaka <[email protected]>
GH-134940 is a backport of this pull request to the 3.14 branch. |
GH-134941 is a backport of this pull request to the 3.13 branch. |
serhiy-storchaka
added a commit
that referenced
this pull request
May 30, 2025
…dump() (GH-134925) (GH-134940) Optional None values are always omitted. (cherry picked from commit 1a89991) Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka
added a commit
that referenced
this pull request
May 30, 2025
…dump() (GH-134925) (GH-134941) Optional None values are always omitted. (cherry picked from commit 1a89991) Co-authored-by: Serhiy Storchaka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optional None values are always omitted.
ast.dump( show_empty = True)
does not show mostNone
values. #134733📚 Documentation preview 📚: https://cpython-previews--134925.org.readthedocs.build/