gh-134538: link to example for windows readonly file handling in function docs #135540
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeroIntensity
approved these changes
Jun 17, 2025
There was a problem hiding this comment.
Thanks!
@zooba or @chris-eibl: As Windows experts, would either of you like to look at this one?
chris-eibl
approved these changes
Jun 17, 2025
|
It's not particularly a Windows-specific example, so it seems like mentioning that might put people off reading it. It's a good example of using the error callback. Also I think we tend to use just "See ..." for examples, rather than "See Also" callouts. But that's a question for the docs WG. |
96a60bb to
1bd0a48
Compare
|
Agree. Removed Windows mention |
|
Thanks @alex-semenyuk for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 18, 2025
…ythonGH-135540) (cherry picked from commit e9b647d) Co-authored-by: alexey semenyuk <[email protected]>
|
GH-135691 is a backport of this pull request to the 3.14 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 18, 2025
…ythonGH-135540) (cherry picked from commit e9b647d) Co-authored-by: alexey semenyuk <[email protected]>
|
GH-135692 is a backport of this pull request to the 3.13 branch. |
zooba
pushed a commit
that referenced
this pull request
Jun 18, 2025
) (cherry picked from commit e9b647d) Co-authored-by: alexey semenyuk <[email protected]>
zooba
pushed a commit
that referenced
this pull request
Jun 18, 2025
) (cherry picked from commit e9b647d) Co-authored-by: alexey semenyuk <[email protected]>
lkollar
pushed a commit
to lkollar/cpython
that referenced
this pull request
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to example for windows readonly file handling in function docs
📚 Documentation preview 📚: https://cpython-previews--135540.org.readthedocs.build/en/135540/library/shutil.html#shutil.rmtree