Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-128627: Emscripten: Add missing semicolon in ios detection code #135590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

hoodmane
Copy link
Contributor

@hoodmane hoodmane commented Jun 16, 2025

This causes a build failure with Emscripten 4.0.8

Copy link
Contributor

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops :-)

@freakboy3742 freakboy3742 enabled auto-merge (squash) June 16, 2025 22:53
@freakboy3742 freakboy3742 merged commit 68b7e1a into python:main Jun 16, 2025
48 checks passed
@miss-islington-app
Copy link

Thanks @hoodmane for the PR, and @freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 16, 2025
@bedevere-app
Copy link

bedevere-app bot commented Jun 16, 2025

GH-135592 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jun 16, 2025
freakboy3742 pushed a commit that referenced this pull request Jun 16, 2025
…code (GH-135590) (#135592)

(cherry picked from commit 68b7e1a)

Co-authored-by: Hood Chatham <[email protected]>
@ryanking13
Copy link
Contributor

Oops. Thanks

@hoodmane hoodmane deleted the emscripten-trampoline-add-semicolon branch June 17, 2025 18:58
lkollar pushed a commit to lkollar/cpython that referenced this pull request Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants