[3.14] gh-134632: Fix build-details.json to use INCLUDEPY path (GH-134633)
#135605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 17, 2025
…thonGH-134633) * pythongh-134632: Fix `build-details.json` to use `INCLUDEPY` path Fix ``build-details.json`` generation to use ``INCLUDEPY``, in order to reference the ``pythonX.Y`` subdirectory of the include directory, as required in :pep:`739`, instead of the top-level include directory. * test_build_details: Add tests for the c_api section * test_build_details: Expect pkgconfig for CPython unconditionally (cherry picked from commit 0d582de) Co-authored-by: Michał Górny <[email protected]>
ca5f2d8 to
7b278db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build-details.json:c_api.headersdoes not include thepythonX.Ydirectory #134632: Fixbuild-details.jsonto useINCLUDEPYpathFix
build-details.jsongeneration to useINCLUDEPY, in order toreference the
pythonX.Ysubdirectory of the include directory, asrequired in :pep:
739, instead of the top-level include directory.test_build_details: Add tests for the c_api section
test_build_details: Expect pkgconfig for CPython unconditionally
(cherry picked from commit 0d582de)
Co-authored-by: Michał Górny [email protected]