gh-135698: Fix Cross-interpreter Queue.full() With Negative/Default max_size #135724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @ericsnowcurrently for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 20, 2025
…ault max_size (pythongh-135724) We weren't handling non-positive maxsize values (including the default) properly in Queue.full(). This change fixes that and adjusts an associated assert. (cherry picked from commit c5ea8e8) Co-authored-by: Eric Snow <[email protected]>
|
GH-135775 is a backport of this pull request to the 3.14 branch. |
|
Sorry, @ericsnowcurrently, I could not cleanly backport this to |
ericsnowcurrently
added a commit
that referenced
this pull request
Jun 20, 2025
…fault max_size (gh-135775) We weren't handling non-positive maxsize values (including the default) properly in Queue.full(). This change fixes that and adjusts an associated assert. (cherry picked from commit c5ea8e8, AKA gh-135724) Co-authored-by: Eric Snow <[email protected]>
ericsnowcurrently
added a commit
to ericsnowcurrently/cpython
that referenced
this pull request
Jun 20, 2025
…ault max_size (pythongh-135724) We weren't handling non-positive maxsize values (including the default) properly in Queue.full(). This change fixes that and adjusts an associated assert.
Comment on lines
+712
to
+714
| *p_is_full = queue->items.maxsize > 0 | ||
| ? queue->items.count == queue->items.maxsize | ||
| : 0; |
There was a problem hiding this comment.
Why not write this as queue->items.count >= queue->items.maxsize?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't handling non-positive
maxsizevalues (including the default) properly inQueue.full(). This change fixes that and adjusts an associated assert._interpqueuesmoduledue to queue being created with negativemaxsize#135698