Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-127146: Skip test_os.test_mode for Emscripten #135764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 21, 2025
Merged

gh-127146: Skip test_os.test_mode for Emscripten #135764

merged 2 commits into from
Jun 21, 2025
+4 −0

Conversation

hoodmane
Copy link
Contributor

@hoodmane hoodmane commented Jun 20, 2025 •
edited by bedevere-app bot
Loading

This always fails in the build bot and always passes for me locally. Skip it for now in order to get the build bot running.

@hoodmane
pythongh-127146: Skip test_os.test_mode for Emscripten
c6848ac 
This always fails in the build bot and always passes for me
locally. Skip it for now in order to get the build bot running.
@bedevere-app bedevere-app bot added awaiting review tests Tests in the Lib/test dir labels Jun 20, 2025
@bedevere-app bedevere-app bot mentioned this pull request Jun 20, 2025
Open
@hoodmane hoodmane requested a review from freakboy3742 June 20, 2025 15:10
@blockchainGuru1018
Copy link

looks good now

@freakboy3742 freakboy3742 added the needs backport to 3.14 bugs and security fixes label Jun 21, 2025
freakboy3742
freakboy3742 approved these changes Jun 21, 2025
View reviewed changes
Copy link
Contributor

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logged #135783 to track the underlying problem once this is merged.

freakboy3742
freakboy3742 reviewed Jun 21, 2025
View reviewed changes
@freakboy3742 freakboy3742 enabled auto-merge (squash) June 21, 2025 05:28
@hoodmane
Copy link
Contributor Author

Thanks!

@freakboy3742 freakboy3742 merged commit f491125 into python:main Jun 21, 2025
69 of 71 checks passed
@miss-islington-app
Copy link

Thanks @hoodmane for the PR, and @freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 21, 2025
@hoodmane @miss-islington
pythongh-127146: Skip test_os.test_mode for Emscripten (pythonGH-135764)
e2bd638 
Temporarily skip test_os.test_mode on Emscripten; this fails consistently
on the buildbot, but not on other test configurations. Reported as pythonGH-135783
for follow up.
(cherry picked from commit f491125)

Co-authored-by: Hood Chatham <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Jun 21, 2025

GH-135784 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jun 21, 2025
freakboy3742 pushed a commit that referenced this pull request Jun 21, 2025
@miss-islington @hoodmane
[3.14] gh-127146: Skip test_os.test_mode for Emscripten (GH-135764) (#…
2b5c904 
…135784)

Temporarily skip test_os.test_mode on Emscripten; this fails consistently
on the buildbot, but not on other test configurations. Reported as GH-135783
for follow up.
(cherry picked from commit f491125)

Co-authored-by: Hood Chatham <[email protected]>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 Android 3.14 (tier-3) has failed when building commit 2b5c904.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1794/builds/271) and take a look at the build logs.
  4. Check if the failure is related to this commit (2b5c904) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1794/builds/271

Summary of the results of the build (if available):

Click to see traceback logs 
Traceback (most recent call last):
  File "/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/asyncio/runners.py", line 118, in run
    return self._loop.run_until_complete(task)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/asyncio/base_events.py", line 687, in run_until_complete
    return future.result()
           ^^^^^^^^^^^^^^^
  File "/Users/android/buildarea/3.14.mhsmith-android-aarch64/build/Android/android.py", line 597, in run_testbed
    async with asyncio.TaskGroup() as tg:
  File "/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/asyncio/taskgroups.py", line 134, in __aexit__
    raise propagate_cancellation_error
  File "/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/asyncio/taskgroups.py", line 110, in __aexit__
    await self._on_completed_fut
asyncio.exceptions.CancelledError

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes

@blockchainGuru1018 blockchainGuru1018 blockchainGuru1018 approved these changes

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hoodmane @blockchainGuru1018 @bedevere-bot @freakboy3742