-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
gh-135788: Support NETRC environment variable in netrc
#135802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
berthin
wants to merge
17
commits into
python:main
Choose a base branch
from
berthin:add_netrc_envvar
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+207
−89
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
4c3c39a
iadd support for the envvar and implement tests
50ca1d0
refactor tests and double check logic for security
f17476b
add documentation
c1e3abf
fix linting issues
d877728
fix doc linting
b46c00a
Add docstrings and fix documentation
45d4f4c
Wrap lines to 80 chars
33ac518
Fix comments
5b9fcfc
Undo security test
21ab173
add versionadded
67a4645
doc change in whatsnew
2715bda
add news.d entry
1ae9bbf
Apply suggestions from code review
berthin 2d60212
clean up
c156440
fix tests
ca3155c
try mocking expanduser to fix windows issues
b4c22e9
undo 80 chars, try again with os_helper.temp_dir
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -65,9 +65,10 @@ def push_token(self, token): | |
|
||
class netrc: | ||
def __init__(self, file=None): | ||
default_netrc = file is None | ||
if file is None: | ||
file = os.path.join(os.path.expanduser("~"), ".netrc") | ||
envvar_netrc = os.environ.get("NETRC", "") | ||
home_netrc = os.path.join(os.path.expanduser("~"), ".netrc") | ||
file = file or envvar_netrc or home_netrc | ||
default_netrc = (file == home_netrc) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The paths may be different but resolve to the same file. |
||
self.hosts = {} | ||
self.macros = {} | ||
try: | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.