Update patchcheck upstream remote verification behavior #135806
Merged
+36
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Running |
|
@ncoghlan Kattni is fine, thank you. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 22, 2025
* find defined "(fetch)" remotes with "python/cpython" in their URL * if there is exactly one, use that remote name * if there is one named "upstream", "origin", or "python", use that remote (in that precedence order) * otherwise report an error listing the defined remotes (cherry picked from commit ac9d37c) Co-authored-by: Kattni <[email protected]>
|
GH-135808 is a backport of this pull request to the 3.14 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 22, 2025
* find defined "(fetch)" remotes with "python/cpython" in their URL * if there is exactly one, use that remote name * if there is one named "upstream", "origin", or "python", use that remote (in that precedence order) * otherwise report an error listing the defined remotes (cherry picked from commit ac9d37c) Co-authored-by: Kattni <[email protected]>
|
GH-135809 is a backport of this pull request to the 3.13 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if you run
patchcheckwithout a remote namedupstreamororigin, it fails with the following error:I ran into this during my first contribution, and it required viewing the source code for
patchcheckto figure out what the issue was.To avoid this for others in the future, I have updated the
patchcheckget_git_upstream_remote()method to be more robust. The following changes have been implemented:git remote -v.python/cpythonand(fetch).upstream,origin, andpython, in that order, and returns the first one it finds.Discussed with @ncoghlan prior to submitting this PR.