Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-133296: Publicly expose critical section API that accepts PyMutex #135899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
colesbury merged 6 commits into from
Jul 21, 2025
Merged

gh-133296: Publicly expose critical section API that accepts PyMutex #135899

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
176aa3d
gh-133296: Publicly expose critical section API that accepts PyMutex
ngoldbaum Jun 24, 2025
e0691f5
fix copy-paste error
ngoldbaum Jun 24, 2025
5640b48
avoid compiler warning on GIL-enabled build
ngoldbaum Jun 24, 2025
6d987c7
Apply suggestions from code review
ngoldbaum Jun 24, 2025
59ac85a
Update changelog
ngoldbaum Jun 24, 2025
95a0be3
fix issue pointed out by Kumar
ngoldbaum Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix copy-paste error
  • Loading branch information
@ngoldbaum
ngoldbaum committed Jun 24, 2025
commit e0691f5020d308c0a9c8e6d55d27fbe31a372a4f
4 changes: 2 additions & 2 deletions Include/cpython/critical_section.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,13 +91,13 @@ PyCriticalSection2_End(PyCriticalSection2 *c);
#ifndef Py_GIL_DISABLED
# define Py_BEGIN_CRITICAL_SECTION(op) \
{
# define Py_BEGIN_CRITICAL_SECTION_MUTEX(mut) \
# define Py_BEGIN_CRITICAL_SECTION_MUTEX(mutex) \
{
# define Py_END_CRITICAL_SECTION() \
}
# define Py_BEGIN_CRITICAL_SECTION2(a, b) \
{
# define Py_BEGIN_CRITICAL_SECTION2_MUTEX(mut) \
# define Py_BEGIN_CRITICAL_SECTION2_MUTEX(m1, m2) \
{
# define Py_END_CRITICAL_SECTION2() \
}
Expand Down