Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-115999: remove redundant check in free-threading from _STORE_ATTR_WITH_HINT #136249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 4, 2025
Merged

gh-115999: remove redundant check in free-threading from _STORE_ATTR_WITH_HINT #136249

merged 2 commits into from
Jul 4, 2025
+0 −25

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Jul 3, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Jul 3, 2025
Closed
@kumaraditya303 kumaraditya303 requested a review from colesbury July 3, 2025 16:01
@colesbury
Copy link
Contributor

You'll need to run make regen-cases

@kumaraditya303
Copy link
Contributor Author

You'll need to run make regen-cases

Sorry, missed that, fixed now

@colesbury colesbury added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 3, 2025
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @colesbury for commit fb7523c 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136249%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 3, 2025
@colesbury
Copy link
Contributor

For posterity: we don't need to re-check _PyObject_GetManagedDict() because LOCK_OBJECT never blocks. If LOCK_OBJECT() blocked (and detached the thread state), then we would have problems because the quiescent state might mean that a replaced manage dictionary could be freed.

@kumaraditya303 kumaraditya303 merged commit 85f092f into python:main Jul 4, 2025
134 of 142 checks passed
@kumaraditya303 kumaraditya303 deleted the special branch July 4, 2025 03:34
AndPuQing pushed a commit to AndPuQing/cpython that referenced this pull request Jul 11, 2025
@kumaraditya303 @AndPuQing
pythongh-115999: remove redundant check in free-threading from `_STOR…
55a5b18 
…E_ATTR_WITH_HINT` (python#136249)
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@kumaraditya303 @Pranjal095
pythongh-115999: remove redundant check in free-threading from `_STOR…
22fcb1b 
…E_ATTR_WITH_HINT` (python#136249)
picnixz pushed a commit to picnixz/cpython that referenced this pull request Jul 13, 2025
@kumaraditya303 @picnixz
pythongh-115999: remove redundant check in free-threading from `_STOR…
809e892 
…E_ATTR_WITH_HINT` (python#136249)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colesbury colesbury colesbury approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees
No one assigned
Labels
skip news topic-free-threading
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kumaraditya303 @colesbury @bedevere-bot