Thanks to visit codestin.com
Credit goes to github.com

Skip to content

bpo-35246: fix support for path-like args in asyncio subprocess #13628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miss-islington merged 4 commits into from
May 29, 2019
Merged

bpo-35246: fix support for path-like args in asyncio subprocess #13628

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d7dc435
bpo-35246: fix support for path-like args in asyncio subprocess
lilydjwg May 28, 2019
b69e116
improve test_subprocess
lilydjwg May 28, 2019
d517ded
Merge remote-tracking branch 'upstream/master' into asyncio-subproces…
lilydjwg May 29, 2019
e337a71
use test.support.FakePath instead of pathlib.Path
lilydjwg May 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions Lib/asyncio/base_events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1605,11 +1605,6 @@ async def subprocess_exec(self, protocol_factory, program, *args,
raise ValueError("errors must be None")

popen_args = (program,) + args
for arg in popen_args:
if not isinstance(arg, (str, bytes)):
raise TypeError(
f"program arguments must be a bytes or text string, "
f"not {type(arg).__name__}")
protocol = protocol_factory()
debug_log = None
if self._debug:
Expand Down
12 changes: 12 additions & 0 deletions Lib/test/test_asyncio/test_subprocess.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -622,6 +622,18 @@ async def execute():
self.loop.run_until_complete(execute())


def test_create_subprocess_exec_with_path(self):
async def execute():
from pathlib import Path
Copy link
Contributor

@asvetlov asvetlov May 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move the import to the top of the module.
Use import pathlib form and pathlib.Path for consistency.

p = await subprocess.create_subprocess_exec(
Path(sys.executable), '-c', 'pass')
await p.wait()
p = await subprocess.create_subprocess_exec(
sys.executable, '-c', 'pass', Path('.'))
await p.wait()

self.loop.run_until_complete(execute())
Copy link
Contributor

@asvetlov asvetlov May 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add self.assertIsNone(loop.run_until_complete(...)) check to emphasize that we checked that the test passed correctly.


if sys.platform != 'win32':
# Unix
class SubprocessWatcherMixin(SubprocessMixin):
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2019-05-28-23-17-35.bpo-35246.oXT21d.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Make :func:`asyncio.create_subprocess_exec` accept path-like arguments.