Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-136571: Convert more code in datetime to Argument Clinic #136573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 6 commits into from
Aug 9, 2025
Merged

gh-136571: Convert more code in datetime to Argument Clinic #136573

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c5f8871
gh-136571: Convert more code in datetime to Argument Clinic
serhiy-storchaka Jul 12, 2025
b832246
Fix const static data.
serhiy-storchaka Jul 12, 2025
b276aac
Polishing.
serhiy-storchaka Jul 12, 2025
a56bc55
Merge branch 'main' into clinic-datetime
serhiy-storchaka Aug 9, 2025
e39b7d6
Only test signatures of the C implementation.
serhiy-storchaka Aug 9, 2025
6e05fb4
Fix typo.
serhiy-storchaka Aug 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Polishing.
  • Loading branch information
@serhiy-storchaka
serhiy-storchaka committed Jul 12, 2025
commit b276aac3b5b81d5faf85f987978cf1e9377de5c2
6 changes: 2 additions & 4 deletions Modules/_datetimemodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3355,8 +3355,7 @@ datetime_date_fromordinal_impl(PyTypeObject *type, int ordinal)
int day;

if (ordinal < 1) {
PyErr_SetString(PyExc_ValueError, "ordinal must be "
">= 1");
PyErr_SetString(PyExc_ValueError, "ordinal must be >= 1");
return NULL;
}
ord_to_ymd(ordinal, &year, &month, &day);
Expand Down Expand Up @@ -6547,8 +6546,7 @@ datetime_richcompare(PyObject *self, PyObject *other, int op)
PyDateTime_Delta *delta;

assert(offset1 != offset2); /* else last "if" handled it */
delta = (PyDateTime_Delta *)datetime_subtract((PyObject *)self,
other);
delta = (PyDateTime_Delta *)datetime_subtract(self, other);
if (delta == NULL)
goto done;
diff = GET_TD_DAYS(delta);
Expand Down
Loading