Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[3.14] gh-127146: Emscripten: Set umask to zero in python.sh (GH-136740) #136745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
freakboy3742 merged 1 commit into from
Jul 17, 2025
+5 −0
Merged

[3.14] gh-127146: Emscripten: Set umask to zero in python.sh (GH-136740) #136745

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
gh-127146: Emscripten: Set umask to zero in python.sh (GH-136740) 
Clears the umask used during a test of pydoc.apropos when testing on
Emscripten. This is to work around a known issue in Emscripten; but it's not
clear if the chmod call that is causing the problem is actually testing
anything of significance.
(cherry picked from commit 22af5d3)

Co-authored-by: Hood Chatham <[email protected]>
  • Loading branch information
@hoodmane @miss-islington
hoodmane authored and miss-islington committed Jul 17, 2025
commit 3c629d6e96037d1f8aeeecaf43fef33159f2be89
5 changes: 5 additions & 0 deletions Lib/test/test_pydoc/test_pydoc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1303,6 +1303,11 @@ def test_apropos_with_unreadable_dir(self):
@os_helper.skip_unless_working_chmod
def test_apropos_empty_doc(self):
pkgdir = os.path.join(TESTFN, 'walkpkg')
if support.is_emscripten:
# Emscripten's readdir implementation is buggy on directories
# with read permission but no execute permission.
old_umask = os.umask(0)
self.addCleanup(os.umask, old_umask)
os.mkdir(pkgdir)
self.addCleanup(rmtree, pkgdir)
init_path = os.path.join(pkgdir, '__init__.py')
Expand Down
Loading