Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-135228: Create __dict__ and __weakref__ descriptors for object #136966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
encukou merged 18 commits into from
Aug 18, 2025
Merged

gh-135228: Create __dict__ and __weakref__ descriptors for object #136966

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
027f629
gh-135228: When @dataclass(slots=True) replaces a dataclass, make the…
JelleZijlstra Jul 20, 2025
c82d86b
Keep just the test
encukou Jul 22, 2025
9ef8632
Create __dict__ and __weakref__ descriptors for `object`
encukou Jul 22, 2025
696f1d0
Adjust internals of inspect.getattr_static
encukou Jul 22, 2025
58c7a39
Merge in the main branch
encukou Jul 22, 2025
d0d2f73
Share __dict__ and __weakref__ descriptors
encukou Jul 30, 2025
f709deb
Merge in the main branch
encukou Jul 30, 2025
dc541cd
Adjust __repr__ of generic descriptors (ones whose __objclass__ is type)
encukou Jul 30, 2025
1e2fd8a
Add PyGetSetDef to c-analyzer's list of types
encukou Jul 30, 2025
9a40a98
Add blurb
encukou Aug 5, 2025
71bd841
Merge in the main branch
encukou Aug 5, 2025
61230e2
Merge in the main branch
encukou Aug 12, 2025
e414d29
Stop calling _clear_type_descriptors
encukou Aug 12, 2025
a71d91a
Remove sys._clear_type_descriptors
encukou Aug 12, 2025
64ebb4f
Add tests for the generic descriptors
encukou Aug 12, 2025
699ea77
Add to What's New
encukou Aug 12, 2025
1909b6d
Add side effect note; apply review suggestions for test
encukou Aug 15, 2025
758669d
Merge branch 'main' into hackweakref-descr
encukou Aug 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Stop calling _clear_type_descriptors
  • Loading branch information
@encukou
encukou committed Aug 12, 2025
commit e414d2985db6e39ce946d4268b922ed5db1cb71b
9 changes: 5 additions & 4 deletions Lib/dataclasses.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1283,10 +1283,6 @@ def _add_slots(cls, is_frozen, weakref_slot, defined_fields):
if '__slots__' in cls.__dict__:
raise TypeError(f'{cls.__name__} already specifies __slots__')

# gh-102069: Remove existing __weakref__ descriptor.
# gh-135228: Make sure the original class can be garbage collected.
sys._clear_type_descriptors(cls)

# Create a new dict for our new class.
cls_dict = dict(cls.__dict__)
field_names = tuple(f.name for f in fields(cls))
Expand All @@ -1304,6 +1300,11 @@ def _add_slots(cls, is_frozen, weakref_slot, defined_fields):
# available in _MARKER.
cls_dict.pop(field_name, None)

# Remove __dict__ and `__weakref__` descriptors.
# They'll be added back if applicable.
cls_dict.pop('__dict__', None)
cls_dict.pop('__weakref__', None) # gh-102069

# And finally create the class.
qualname = getattr(cls, '__qualname__', None)
newcls = type(cls)(cls.__name__, cls.__bases__, cls_dict)
Expand Down