Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-135329: prevent infinite traceback loop on Ctrl-C for strace #138133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ambv merged 18 commits into from
Sep 16, 2025
Merged

gh-135329: prevent infinite traceback loop on Ctrl-C for strace #138133

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
ede576f
fix: strace ./python will forever loop
yihong0618 Aug 25, 2025
9235522
fix: add news
yihong0618 Aug 25, 2025
5ff6b9b
fix: address comments
yihong0618 Aug 25, 2025
d37d318
fix: address comments and add tests
yihong0618 Aug 25, 2025
f33f4ad
fix: address comments
yihong0618 Aug 26, 2025
851476b
fix: add EIO erorr with strace test
yihong0618 Sep 1, 2025
9658e5f
Merge branch 'hy/fix_can_not_strace' of https://github.com/yihong0618…
yihong0618 Sep 1, 2025
d54f137
fix: address comments
yihong0618 Sep 2, 2025
f441dca
fix: raise EIO without strace
yihong0618 Sep 2, 2025
0fc6c4a
fix: import sort
yihong0618 Sep 2, 2025
ac14061
fix: use spawn_python
yihong0618 Sep 3, 2025
41e191e
Update Lib/_pyrepl/unix_console.py
yihong0618 Sep 12, 2025
e3ae9a2
fix: apply comments
yihong0618 Sep 12, 2025
f463849
fix: test on windows
yihong0618 Sep 12, 2025
1801806
Run the internal EIO test on any non-win32 plat
ambv Sep 16, 2025
d0f9659
Merge branch 'main' into pr-138133
ambv Sep 16, 2025
e4a9a67
Apply suggestions from code review
ambv Sep 16, 2025
643f368
Treat ENXIO as success
ambv Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: apply comments 
Signed-off-by: yihong0618 <[email protected]>
  • Loading branch information
@yihong0618
yihong0618 committed Sep 12, 2025
commit e3ae9a21c9787ac28f34a1f94772a04838be7719
99 changes: 99 additions & 0 deletions Lib/test/test_pyrepl/eio_test_script.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,99 @@
import os
import sys
import pty
import fcntl
import termios
import signal
import errno
Comment thread
ambv marked this conversation as resolved.
Outdated


def handler(sig, f):
pass


def create_eio_condition():
Comment thread
ambv marked this conversation as resolved.
try:
# gh-135329: try to create a condition that will actually produce EIO
Comment thread
ambv marked this conversation as resolved.
Outdated
master_fd, slave_fd = pty.openpty()
child_pid = os.fork()
if child_pid == 0:
try:
os.setsid()
fcntl.ioctl(slave_fd, termios.TIOCSCTTY, 0)
p2_pgid = os.getpgrp()
Comment thread
ambv marked this conversation as resolved.
Outdated
grandchild_pid = os.fork()
if grandchild_pid == 0:
# Grandchild - set up process group
os.setpgid(0, 0)
# Redirect stdin to slave
os.dup2(slave_fd, 0)
Comment thread
ambv marked this conversation as resolved.
Outdated
if slave_fd > 2:
os.close(slave_fd)
# Fork great-grandchild for terminal control manipulation
ggc_pid = os.fork()
if ggc_pid == 0:
Comment thread
ambv marked this conversation as resolved.
Outdated
# Great-grandchild - just exit quickly
sys.exit(0)
Comment thread
ambv marked this conversation as resolved.
Outdated
else:
# Back to grandchild
try:
os.tcsetpgrp(0, p2_pgid)
except OSError:
pass
sys.exit(0)
Comment thread
ambv marked this conversation as resolved.
Outdated
else:
# Back to child
try:
os.setpgid(grandchild_pid, grandchild_pid)
except ProcessLookupError:
pass
os.tcsetpgrp(slave_fd, grandchild_pid)
if slave_fd > 2:
os.close(slave_fd)
os.waitpid(grandchild_pid, 0)
# Manipulate terminal control to create EIO condition
os.tcsetpgrp(master_fd, p2_pgid)
# Now try to read from master - this might cause EIO
try:
os.read(master_fd, 1)
except OSError as e:
if e.errno == errno.EIO:
print(f"Setup created EIO condition: {e}", file=sys.stderr)
sys.exit(0)
except Exception as setup_e:
print(f"Setup error: {setup_e}", file=sys.stderr)
sys.exit(1)
else:
# Parent process
os.close(slave_fd)
os.waitpid(child_pid, 0)
# Now replace stdin with master_fd and try to read
os.dup2(master_fd, 0)
os.close(master_fd)
# This should now trigger EIO
result = input()
print(f"Unexpectedly got input: {repr(result)}", file=sys.stderr)
sys.exit(0)
Comment thread
ambv marked this conversation as resolved.
Outdated
except OSError as e:
if e.errno == errno.EIO:
print(f"Got EIO: {e}", file=sys.stderr)
sys.exit(1)
elif e.errno == errno.ENXIO:
print(f"Got ENXIO (no such device): {e}", file=sys.stderr)
sys.exit(1) # Treat ENXIO as success too
else:
print(f"Got other OSError: errno={e.errno} {e}", file=sys.stderr)
sys.exit(2)
except EOFError as e:
print(f"Got EOFError: {e}", file=sys.stderr)
sys.exit(3)
except Exception as e:
print(f"Got unexpected error: {type(e).__name__}: {e}", file=sys.stderr)
sys.exit(4)


if __name__ == "__main__":
# Set up signal handler for coordination
signal.signal(signal.SIGUSR1, lambda *a: create_eio_condition())
print("READY", flush=True)
signal.pause()
114 changes: 7 additions & 107 deletions Lib/test/test_pyrepl/test_unix_console.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,14 @@
import errno
import itertools
import os
import signal
import subprocess
import sys
import unittest
import termios
Comment thread
yihong0618 marked this conversation as resolved.
Outdated
import unittest
from functools import partial
from test.support import os_helper, force_not_colorized_test_class
from test.support import script_helper
import subprocess
import signal
import textwrap

from unittest import TestCase
from unittest.mock import MagicMock, call, patch, ANY, Mock
Expand Down Expand Up @@ -331,115 +330,16 @@ def test_eio_error_handling_in_restore(self, mock_tcgetattr, mock_tcsetattr):

mock_tcsetattr.side_effect = termios.error(errno.EIO, "Input/output error")

try:
console.restore()
except termios.error as e:
if e.args[0] == errno.EIO:
self.fail("EIO error should have been handled gracefully in restore()")
raise
# EIO error should be handled gracefully in restore()
console.restore()

@unittest.skipUnless(sys.platform == "linux", "Only valid on Linux")
def test_repl_eio(self):
# Use the pty-based approach to simulate EIO error
child_code = textwrap.dedent("""
import os, sys, pty, fcntl, termios, signal, time, errno

def handler(sig, f):
pass

def create_eio_condition():
try:
# Try to create a condition that will actually produce EIO
# Method: Use your original script's approach with modifications
master_fd, slave_fd = pty.openpty()
# Fork a child that will manipulate the pty
child_pid = os.fork()
if child_pid == 0:
# Child process
try:
# Set up session and control terminal like your script
os.setsid()
fcntl.ioctl(slave_fd, termios.TIOCSCTTY, 0)
# Get process group
p2_pgid = os.getpgrp()
# Fork grandchild
grandchild_pid = os.fork()
if grandchild_pid == 0:
# Grandchild - set up process group
os.setpgid(0, 0)
# Redirect stdin to slave
os.dup2(slave_fd, 0)
if slave_fd > 2:
os.close(slave_fd)
# Fork great-grandchild for terminal control manipulation
ggc_pid = os.fork()
if ggc_pid == 0:
# Great-grandchild - just exit quickly
sys.exit(0)
else:
# Back to grandchild
try:
os.tcsetpgrp(0, p2_pgid)
except:
pass
sys.exit(0)
else:
# Back to child
try:
os.setpgid(grandchild_pid, grandchild_pid)
except ProcessLookupError:
pass
os.tcsetpgrp(slave_fd, grandchild_pid)
if slave_fd > 2:
os.close(slave_fd)
os.waitpid(grandchild_pid, 0)
# Manipulate terminal control to create EIO condition
os.tcsetpgrp(master_fd, p2_pgid)
# Now try to read from master - this might cause EIO
try:
os.read(master_fd, 1)
except OSError as e:
if e.errno == errno.EIO:
print(f"Setup created EIO condition: {e}", file=sys.stderr)
sys.exit(0)
except Exception as setup_e:
print(f"Setup error: {setup_e}", file=sys.stderr)
sys.exit(1)
else:
# Parent process
os.close(slave_fd)
os.waitpid(child_pid, 0)
# Now replace stdin with master_fd and try to read
os.dup2(master_fd, 0)
os.close(master_fd)
# This should now trigger EIO
result = input()
print(f"Unexpectedly got input: {repr(result)}", file=sys.stderr)
sys.exit(0)
except OSError as e:
if e.errno == errno.EIO:
print(f"Got EIO: {e}", file=sys.stderr)
sys.exit(1)
elif e.errno == errno.ENXIO:
print(f"Got ENXIO (no such device): {e}", file=sys.stderr)
sys.exit(1) # Treat ENXIO as success too
else:
print(f"Got other OSError: errno={e.errno} {e}", file=sys.stderr)
sys.exit(2)
except EOFError as e:
print(f"Got EOFError: {e}", file=sys.stderr)
sys.exit(3)
except Exception as e:
print(f"Got unexpected error: {type(e).__name__}: {e}", file=sys.stderr)
sys.exit(4)
# Set up signal handler for coordination
signal.signal(signal.SIGUSR1, lambda *a: create_eio_condition())
print("READY", flush=True)
signal.pause()
""").strip()
script_path = os.path.join(os.path.dirname(__file__), "eio_test_script.py")

proc = script_helper.spawn_python(
"-S", "-c", child_code,
"-S", script_path,
stderr=subprocess.PIPE,
text=True
)
Expand Down
Loading