Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-135329: prevent infinite traceback loop on Ctrl-C for strace #138133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ambv merged 18 commits into from
Sep 16, 2025
Merged

gh-135329: prevent infinite traceback loop on Ctrl-C for strace #138133

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
ede576f
fix: strace ./python will forever loop
yihong0618 Aug 25, 2025
9235522
fix: add news
yihong0618 Aug 25, 2025
5ff6b9b
fix: address comments
yihong0618 Aug 25, 2025
d37d318
fix: address comments and add tests
yihong0618 Aug 25, 2025
f33f4ad
fix: address comments
yihong0618 Aug 26, 2025
851476b
fix: add EIO erorr with strace test
yihong0618 Sep 1, 2025
9658e5f
Merge branch 'hy/fix_can_not_strace' of https://github.com/yihong0618…
yihong0618 Sep 1, 2025
d54f137
fix: address comments
yihong0618 Sep 2, 2025
f441dca
fix: raise EIO without strace
yihong0618 Sep 2, 2025
0fc6c4a
fix: import sort
yihong0618 Sep 2, 2025
ac14061
fix: use spawn_python
yihong0618 Sep 3, 2025
41e191e
Update Lib/_pyrepl/unix_console.py
yihong0618 Sep 12, 2025
e3ae9a2
fix: apply comments
yihong0618 Sep 12, 2025
f463849
fix: test on windows
yihong0618 Sep 12, 2025
1801806
Run the internal EIO test on any non-win32 plat
ambv Sep 16, 2025
d0f9659
Merge branch 'main' into pr-138133
ambv Sep 16, 2025
e4a9a67
Apply suggestions from code review
ambv Sep 16, 2025
643f368
Treat ENXIO as success
ambv Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 29 additions & 2 deletions Lib/_pyrepl/unix_console.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,17 @@ def prepare(self):
raw.lflag |= termios.ISIG
raw.cc[termios.VMIN] = 1
raw.cc[termios.VTIME] = 0
tcsetattr(self.input_fd, termios.TCSADRAIN, raw)
try:
tcsetattr(self.input_fd, termios.TCSADRAIN, raw)
except termios.error as e:
if e.args[0] == errno.EIO:
# gh-135329
# When running under external programs (like strace),
# tcsetattr may fail with EIO. We can safely ignore this
# and continue with default terminal settings.
Comment thread
yihong0618 marked this conversation as resolved.
Outdated
pass
else:
raise
Comment thread
yihong0618 marked this conversation as resolved.
Outdated

# In macOS terminal we need to deactivate line wrap via ANSI escape code
if platform.system() == "Darwin" and os.getenv("TERM_PROGRAM") == "Apple_Terminal":
Expand Down Expand Up @@ -368,7 +378,17 @@ def restore(self):
self.__disable_bracketed_paste()
self.__maybe_write_code(self._rmkx)
self.flushoutput()
tcsetattr(self.input_fd, termios.TCSADRAIN, self.__svtermstate)
try:
tcsetattr(self.input_fd, termios.TCSADRAIN, self.__svtermstate)
except termios.error as e:
if e.args[0] == errno.EIO:
# gh-135329
# When running under external programs (like strace),
# tcsetattr may fail with EIO. We can safely ignore this
# as the terminal state will be restored by the external program.
pass
else:
raise

Comment thread
yihong0618 marked this conversation as resolved.
if platform.system() == "Darwin" and os.getenv("TERM_PROGRAM") == "Apple_Terminal":
os.write(self.output_fd, b"\033[?7h")
Expand Down Expand Up @@ -407,6 +427,13 @@ def get_event(self, block: bool = True) -> Event | None:
return self.event_queue.get()
else:
continue
elif err.errno == errno.EIO:
# gh-135329
# When running under external programs (like strace),
# os.read may fail with EIO. In this case, we should
# exit gracefully to avoid infinite error loops.
Comment thread
yihong0618 marked this conversation as resolved.
Outdated
import sys
sys.exit(errno.EIO)
Comment thread
yihong0618 marked this conversation as resolved.
Outdated
else:
raise
else:
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2025-08-25-18-06-04.gh-issue-138133.Zh9rGo.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
prevent infinite traceback loop on Ctrl-C for strace
Comment thread
yihong0618 marked this conversation as resolved.
Outdated
Loading