Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-137838: Fix JIT trace buffer overrun by pre-reserving exit stub space #138173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
corona10 wants to merge 8 commits into from
Closed

gh-137838: Fix JIT trace buffer overrun by pre-reserving exit stub space #138173

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0776a59
gh-137838: Fix JIT trace buffer overrun by pre-reserving exit stub space
corona10 Aug 27, 2025
eff78b4
Add NEWS.d
corona10 Aug 27, 2025
dbc5d9a
Revert "gh-137838: Fix JIT trace buffer overrun by pre-reserving exit…
corona10 Aug 27, 2025
76eec2d
update
corona10 Aug 27, 2025
2a77ad0
Update comment
corona10 Aug 27, 2025
18a8161
lint
corona10 Aug 27, 2025
1d54d87
fix
corona10 Aug 27, 2025
a4e666d
revert to 20%....
corona10 Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix
  • Loading branch information
@corona10
corona10 committed Aug 27, 2025
commit 1d54d8701a460d26e1aebe45a8dba6a514dd3c9d
7 changes: 4 additions & 3 deletions Python/optimizer.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -564,7 +564,8 @@ translate_bytecode_to_trace(
* Assumption: 67% reserved for trace, 33% for exit stubs
* TODO: Compute the required number of exit stubs dynamically
*/
int max_length = (buffer_size * 2) / 3;
int max_exit_stubs = (buffer_size * 33) / 100; // 33% for exit stubs
int max_length = buffer_size - 2 - max_exit_stubs;
struct {
PyFunctionObject *func;
PyCodeObject *code;
Expand Down Expand Up @@ -724,9 +725,9 @@ translate_bytecode_to_trace(
{
const struct opcode_macro_expansion *expansion = &_PyOpcode_macro_expansion[opcode];
if (expansion->nuops > 0) {
// Reserve space for nuops (+ _SET_IP + _EXIT_TRACE)
// Reserve space for nuops (exit stub space already pre-reserved)
int nuops = expansion->nuops;
RESERVE(nuops + 1); /* One extra for exit */
RESERVE(nuops);
int16_t last_op = expansion->uops[nuops-1].uop;
if (last_op == _RETURN_VALUE || last_op == _RETURN_GENERATOR || last_op == _YIELD_VALUE) {
// Check for trace stack underflow now:
Expand Down
Loading