Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-129813, PEP 782: Use PyBytesWriter in _io.FileIO.readall #138901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 3 commits into from
Sep 15, 2025
Merged

gh-129813, PEP 782: Use PyBytesWriter in _io.FileIO.readall #138901

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
86b9f6b
gh-129813, PEP 782: Use PyBytesWriter in _io.FileIO.readall
cmaloney Sep 15, 2025
b644ffb
Fix MSVC C2036 warning by casting to char to match what PyBytes_AS_ST…
cmaloney Sep 15, 2025
c6d5485
Remove News; no impact on end users
cmaloney Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix MSVC C2036 warning by casting to char to match what PyBytes_AS_ST… 
…RING did
  • Loading branch information
@cmaloney
cmaloney committed Sep 15, 2025
commit b644ffbbd9148454638d933abf348228e7284360
2 changes: 1 addition & 1 deletion Modules/_io/fileio.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -817,7 +817,7 @@ _io_FileIO_readall_impl(fileio *self)
}

n = _Py_read(self->fd,
PyBytesWriter_GetData(writer) + bytes_read,
(char*)PyBytesWriter_GetData(writer) + bytes_read,
bufsize - bytes_read);

if (n == 0)
Expand Down
Loading