Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-135125: Fix Py_STACKREF_DEBUG build #139475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markshannon merged 5 commits into from
Oct 23, 2025
Merged

gh-135125: Fix Py_STACKREF_DEBUG build #139475

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e0ea1b1
Fixes for PyStackRefs in debug builds.
efimov-mikhail Oct 1, 2025
56a2076
The same pattern of refcounting for stackrefs as in production build
efimov-mikhail Oct 3, 2025
89cd750
Merge branch 'main' into issue_135379_stackref_debug_fixes
efimov-mikhail Oct 22, 2025
a2754b7
Adoption after merge main, review addressed
efimov-mikhail Oct 22, 2025
14b89e5
Address review
efimov-mikhail Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Address review
  • Loading branch information
@efimov-mikhail
efimov-mikhail committed Oct 23, 2025
commit 14b89e5bc8e6b8a8c1ff8b919c366b7d0a54bc28
3 changes: 2 additions & 1 deletion Include/internal/pycore_stackref.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,6 +289,7 @@ _PyStackRef_Borrow(_PyStackRef ref, const char *filename, int linenumber)
static inline _PyStackRef
_PyStackRef_FromPyObjectStealMortal(PyObject *obj, const char *filename, int linenumber)
{
assert(obj != NULL);
assert(!_Py_IsImmortal(obj));
return _Py_stackref_create(obj, 0, filename, linenumber);
}
Expand Down Expand Up @@ -324,7 +325,7 @@ _PyStackRef_FromPyObjectNewMortal(PyObject *obj, const char *filename, int linen
{
assert(obj != NULL);
assert(!_Py_IsStaticImmortal(obj));
Comment thread
sergey-miryanov marked this conversation as resolved.
Py_XINCREF(obj);
Py_INCREF(obj);
return _Py_stackref_create(obj, 0, filename, linenumber);
}
#define PyStackRef_FromPyObjectNewMortal(obj) _PyStackRef_FromPyObjectNewMortal(_PyObject_CAST(obj), __FILE__, __LINE__)
Expand Down
Loading