Thanks to visit codestin.com
Credit goes to github.com

Skip to content

GH-139809: Fix argparse subcommand prog not respecting color environment variables #139818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
savannahostrowski merged 9 commits into from
Oct 9, 2025
Merged

GH-139809: Fix argparse subcommand prog not respecting color environment variables #139818

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1e3e343
Add fix to decolorize and test
savannahostrowski Oct 9, 2025
8511193
Remove extra line
savannahostrowski Oct 9, 2025
c94021b
📜🤖 Added by blurb_it.
blurb-it[bot] Oct 9, 2025
98b78b6
Remove parens in blurb
savannahostrowski Oct 9, 2025
666dd43
Use formatter class to avoid premature colorization of prog
savannahostrowski Oct 9, 2025
f2c813a
Update blurb
savannahostrowski Oct 9, 2025
5ba525a
Update test
savannahostrowski Oct 9, 2025
86551d1
Move blurb and simplify setUp
savannahostrowski Oct 9, 2025
8274bc7
Merge branch 'main' into fix-colorize-subparser
savannahostrowski Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update test
  • Loading branch information
@savannahostrowski
savannahostrowski committed Oct 9, 2025
commit 5ba525a862f8ee8cf7fe4de8d7cfdc224fda3d7c
23 changes: 7 additions & 16 deletions Lib/test/test_argparse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7128,7 +7128,9 @@ class TestColorized(TestCase):
def setUp(self):
super().setUp()
# Ensure color even if ran with NO_COLOR=1
original_can_colorize = _colorize.can_colorize
_colorize.can_colorize = lambda *args, **kwargs: True
self.addCleanup(setattr, _colorize, 'can_colorize', original_can_colorize)
Comment thread
savannahostrowski marked this conversation as resolved.
Outdated
self.theme = _colorize.get_theme(force_color=True).argparse

def test_argparse_color(self):
Expand Down Expand Up @@ -7355,29 +7357,18 @@ def __init__(self, prog):
{short_b}+f{reset}, {long_b}++foo{reset} {label_b}FOO{reset} foo help
'''))


class TestColorEnvironment(TestCase):
"""Tests for color behavior with environment variable changes."""

def test_subparser_respects_no_color_environment(self):
# Cleanup to ensure environment is properly reset
self.addCleanup(os.environ.pop, 'FORCE_COLOR', None)
self.addCleanup(os.environ.pop, 'NO_COLOR', None)

# Create parser with FORCE_COLOR, capturing colored prog
os.environ['FORCE_COLOR'] = '1'
parser = argparse.ArgumentParser(prog='complex')
def test_subparser_prog_is_stored_without_color(self):
parser = argparse.ArgumentParser(prog='complex', color=True)
sub = parser.add_subparsers(dest='command')
demo_parser = sub.add_parser('demo')

# Switch to NO_COLOR environment
os.environ.pop('FORCE_COLOR', None)
os.environ['NO_COLOR'] = '1'
self.assertNotIn('\x1b[', demo_parser.prog)

# Subparser help should have no color codes
demo_parser.color = False
help_text = demo_parser.format_help()
self.assertNotIn('\x1b[', help_text)


class TestModule(unittest.TestCase):
def test_deprecated__version__(self):
with self.assertWarnsRegex(
Expand Down
Loading