bpo-29453: Remove reference to undefined dictionary ordering in Tutorial #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of Python 3.6 **kwargs are ordered, thus, remove the paragraph stating that ordering is undefined and change snippet to remove the unecessary sorted call.
|
Added a sentence mentioning the guaranteed output order. Should I also make a PR for |
|
Thanks @DimitrisJim |
|
Assigning this to myself per request by @rhettinger http://bugs.python.org/issue29453 |
|
Thanks, @Mariatta! |
Mariatta
approved these changes
Feb 21, 2017
Mariatta
pushed a commit
to Mariatta/cpython
that referenced
this pull request
Feb 21, 2017
…ial (pythonGH-140) As of Python 3.6 **kwargs are ordered, thus, remove the paragraph stating that ordering is undefined and change snippet to remove the unecessary sorted call. * Add sentence mentioning guaranteed output order of kwargs (cherry picked from commit 32e8f9b)
akruis
pushed a commit
to akruis/cpython
that referenced
this pull request
Oct 29, 2017
- Initialize variable 'len' in function unwrap_frame_arg(). - Assign to '*valid' in function slp_find_execname(). - Disable GCC warning -Waddress in macro TASKLET_SETVAL(task, val). - Update Stackless/changelog.txt for issues python#138, python#140
akruis
pushed a commit
to akruis/cpython
that referenced
this pull request
Nov 7, 2017
- fix a warning about an unused expression result in ceval.c - fix a warning about a non literal NULL-pointer initialization in prickelpit.c (cherry picked from commit 2b68ad3)
akruis
pushed a commit
to akruis/cpython
that referenced
this pull request
Nov 7, 2017
- remove an unused declaration. (cherry picked from commit e20d523)
akruis
pushed a commit
to akruis/cpython
that referenced
this pull request
Nov 7, 2017
Fix warnings emitted by gcc 7.2. - ceval.c: '*' in boolean context, suggest '&&' instead. - stacklessmodule.c: a misleading indentation (cherry picked from commit c51072e)
akruis
pushed a commit
to akruis/cpython
that referenced
this pull request
Mar 25, 2018
- fix a warning about an unused expression result in ceval.c - fix a warning about a non literal NULL-pointer initialization in prickelpit.c
akruis
pushed a commit
to akruis/cpython
that referenced
this pull request
Mar 25, 2018
- remove an unused declaration.
akruis
pushed a commit
to akruis/cpython
that referenced
this pull request
Mar 25, 2018
Fix warnings emitted by gcc 7.2. - ceval.c: '*' in boolean context, suggest '&&' instead. - stacklessmodule.c: a misleading indentation
akruis
pushed a commit
to akruis/cpython
that referenced
this pull request
Jun 19, 2018
- Assign to '*valid' in function slp_find_execname(). - Disable GCC warning -Waddress in macro TASKLET_SETVAL(task, val). - Update Stackless/changelog.txt for issues python#138, python#140 (cherry picked from commit 3461ccf)
akruis
pushed a commit
to akruis/cpython
that referenced
this pull request
Jun 19, 2018
- remove an unused declaration.
akruis
pushed a commit
to akruis/cpython
that referenced
this pull request
Jun 19, 2018
Fix warnings emitted by gcc 7.2. - stacklessmodule.c: a misleading indentation (cherry picked from commit c51072e)
jaraco
pushed a commit
that referenced
this pull request
Dec 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of Python 3.6 **kwargs are ordered, thus, remove the paragraph stating that
ordering is undefined and change snippet to remove the unnecessary sorted call.
Only issue that might need addressing as raised on the tracker is, if it is worth to mention that the output corresponds to the order of passed keyword arguments.
(Though this was already present with a patch on b.p.o I decided to turn it in a pull request since, I believe, it makes it easier to check and apply now that things are on Github)