Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-136702: Deprecate passing non-ascii *encoding* (str) to encodings.normalize_encoding #140030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
malemburg merged 11 commits into from
Nov 9, 2025
Merged

gh-136702: Deprecate passing non-ascii *encoding* (str) to encodings.normalize_encoding #140030

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
c8fc658
deprecate non-ascii
StanFromIreland Oct 13, 2025
5b50daa
Relocate import
StanFromIreland Oct 13, 2025
95f2e65
sanitize charset names in email
StanFromIreland Oct 13, 2025
fad52cd
Use table, replace with 'ascii'
StanFromIreland Oct 16, 2025
3ac0804
Merge branch 'main' into encodings/non-ascii
StanFromIreland Oct 31, 2025
9d6f06e
Review
StanFromIreland Nov 1, 2025
16697dc
Fix second warning
StanFromIreland Nov 1, 2025
e4036f8
Convert to asserts
StanFromIreland Nov 1, 2025
b8fc5f4
Fix for platforms with ordered tests
StanFromIreland Nov 1, 2025
7592af8
!fixup
StanFromIreland Nov 1, 2025
8c59899
Fix CI on Android and iOS
StanFromIreland Nov 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix CI on Android and iOS
  • Loading branch information
@StanFromIreland
StanFromIreland committed Nov 2, 2025
commit 8c598998597aff232a6fbbbdc34f1d17e73f3506
4 changes: 4 additions & 0 deletions Lib/email/_header_value_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -796,6 +796,10 @@ def params(self):
value = urllib.parse.unquote(value, encoding='latin-1')
else:
try:
# Explicitly look up the codec for warning generation, see gh-140030
# Can be removed in 3.17
import codecs
codecs.lookup(charset)
value = value.decode(charset, 'surrogateescape')
except (LookupError, UnicodeEncodeError):
# XXX: there should really be a custom defect for
Expand Down
4 changes: 4 additions & 0 deletions Lib/email/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,6 +460,10 @@ def collapse_rfc2231_value(value, errors='replace',
charset = fallback_charset
rawbytes = bytes(text, 'raw-unicode-escape')
try:
# Explicitly look up the codec for warning generation, see gh-140030
# Can be removed in 3.17
import codecs
codecs.lookup(charset)
return str(rawbytes, charset, errors)
except LookupError:
# charset is not a known codec.
Expand Down
Loading