Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-140149: use PyBytesWriter in action_helpers.c's _build_concatenated_bytes; 3x faster bytes concat in the parser #140150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 6 commits into from
Oct 16, 2025
Merged

gh-140149: use PyBytesWriter in action_helpers.c's _build_concatenated_bytes; 3x faster bytes concat in the parser #140150

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
692a4f0
use PyBytesWriter in _build_concatenated_bytes
maurycy Oct 15, 2025
904fe91
no var read twice
maurycy Oct 15, 2025
bde6eaf
NEWS
maurycy Oct 15, 2025
e5b07d6
Update Parser/action_helpers.c
maurycy Oct 15, 2025
9955759
Update Parser/action_helpers.c
maurycy Oct 15, 2025
3d375ce
Update Misc/NEWS.d/next/Core_and_Builtins/2025-10-15-17-12-32.gh-issu…
vstinner Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update Parser/action_helpers.c 
Co-authored-by: Victor Stinner <[email protected]>
  • Loading branch information
@maurycy @vstinner
maurycy and vstinner authored Oct 15, 2025
commit e5b07d69b8057aabccbfe8e8be57d3e9b67437f4
2 changes: 1 addition & 1 deletion Parser/action_helpers.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1634,8 +1634,8 @@ _build_concatenated_bytes(Parser *p, asdl_expr_seq *strings, int lineno,
if (writer == NULL) {
return NULL;
}

char *out = PyBytesWriter_GetData(writer);
Comment thread
maurycy marked this conversation as resolved.

for (Py_ssize_t i = 0; i < len; i++) {
expr_ty elem = asdl_seq_GET(strings, i);
Comment thread
vstinner marked this conversation as resolved.
PyObject *bytes = elem->v.Constant.value;
Expand Down
Loading