Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-140476: Optimize PySet_Add() for frozenset in free-threading #140440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kumaraditya303 merged 6 commits into from
Nov 11, 2025
Merged

gh-140476: Optimize PySet_Add() for frozenset in free-threading #140440

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d1aaf9a
Optimize PySet_Add for uniquely referenced sets in free-threading
yoney Oct 21, 2025
37ac4ce
Improve comments
yoney Oct 22, 2025
48a4017
Add news entry
yoney Oct 22, 2025
0932e16
Only for frozenset
yoney Oct 23, 2025
68ecfe5
Fix the condition
yoney Oct 23, 2025
c22066f
Merge branch 'main' into ft_set_frozenset
kumaraditya303 Nov 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Only for frozenset
  • Loading branch information
@yoney
yoney committed Oct 23, 2025
commit 0932e1641181891ca904149183f8b4dc1508740f
4 changes: 2 additions & 2 deletions Misc/NEWS.d/next/Core_and_Builtins/2025-10-22-12-48-05.gh-issue-140476.F3-d1P.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
Optimize :c:func:`PySet_Add` for uniquely referenced sets in :term:`free
threaded <free threading>` build.
Optimize :c:func:`PySet_Add` for :class:`frozenset` in :term:`free threaded
<free threading>` build.
15 changes: 8 additions & 7 deletions Objects/setobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2773,13 +2773,6 @@ PySet_Discard(PyObject *set, PyObject *key)
int
PySet_Add(PyObject *anyset, PyObject *key)
{
if (_PyObject_IsUniquelyReferenced(anyset) && PyAnySet_Check(anyset)) {
// We can only change frozensets if they are uniquely referenced,
// and we can avoid locking sets even in free-threaded build if they
// are uniquely referenced.
return set_add_key((PySetObject *)anyset, key);
}

if (PySet_Check(anyset)) {
int rv;
Py_BEGIN_CRITICAL_SECTION(anyset);
Expand All @@ -2788,6 +2781,14 @@ PySet_Add(PyObject *anyset, PyObject *key)
return rv;
}

if (PyFrozenSet_Check(anyset) || _PyObject_IsUniquelyReferenced(anyset)) {
// We can only change frozensets if they are uniquely referenced. The
// API limits the usage of `PySet_Add` to "fill in the values of brand
// new frozensets before they are exposed to other code". In this case,
// this can be done without a lock.
return set_add_key((PySetObject *)anyset, key);
}

PyErr_BadInternalCall();
return -1;
}
Expand Down
Loading