gh-140381: Handle slower machines in test_profiling#140460
Closed
stefanor wants to merge 3 commits intopython:mainfrom
Closed
gh-140381: Handle slower machines in test_profiling#140460stefanor wants to merge 3 commits intopython:mainfrom
stefanor wants to merge 3 commits intopython:mainfrom
Conversation
1b72605 to
6cd4b10
Compare
Contributor
Author
After seeing that Fedora hit this one of of the tests that ran with |
While looking at python#140028 I found some test failures that are caused by new tests (from python#138122) running too slowly. This adds an arbitrary heuristic to 10x the sampling run time (to the default value of 10 seconds). Doubling the 1-second duration was sufficient for my HP PA tests, but Fedora reported one of the 2-second durations being too slow for a freethreaded build. This heuristic could move into test_support. Thoughts?
6cd4b10 to
4f18889
Compare
Member
|
Thanks for the PR but unfortunately this solution looks flaky. I am not sure it will generalize to all the machines and we cannot just have hardcoded numbers. I think that I would try something like what @zooba proposes in #140381 (comment) |
Contributor
Author
|
Yep, that looks a lot cleaner! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While looking at #140028 I found some test failures that are caused by new tests (from #138122) running too slowly.
This adds an arbitrary heuristic to 10x the sampling run time (to the default value of 10 seconds). Doubling the 1-second duration was sufficient for my HP PA tests, but Fedora reported one of the 2-second durations being too slow for a freethreaded build.
test_profilingflaky fail on i686/s390x builds in Fedora Linux #140381