Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[3.9] gh-98793: Fix typecheck in overlapped.c (GH-98835) (GH-98890) #140825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ambv merged 3 commits into from
Oct 31, 2025
Merged

[3.9] gh-98793: Fix typecheck in overlapped.c (GH-98835) (GH-98890) #140825

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
561bd00
[3.9] gh-98793: Fix typecheck in `overlapped.c` (GH-98835) (GH-98890)
CharlieZhao95 Oct 31, 2022
97e53c4
Switch overlapped_WSAConnect() and Overlapped_WSASendTo() to METH_FAS…
ambv Oct 31, 2025
0cbe5e4
Minimize diff: use METH_VARARGS again
encukou Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Switch overlapped_WSAConnect() and Overlapped_WSASendTo() to METH_FAS… 
…TCALL
  • Loading branch information
@ambv
ambv committed Oct 31, 2025
commit 97e53c4015ca2964e49c8b684c1c1b23d142e335
16 changes: 9 additions & 7 deletions Modules/overlapped.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1543,7 +1543,7 @@ PyDoc_STRVAR(
* _only_ be used for connectionless sockets (UDP).
*/
static PyObject *
overlapped_WSAConnect(PyObject *self, PyObject *args)
overlapped_WSAConnect(PyObject *self, PyObject *args, Py_ssize_t nargs)
{
SOCKET ConnectSocket;
PyObject *AddressObj;
Expand All @@ -1552,7 +1552,9 @@ overlapped_WSAConnect(PyObject *self, PyObject *args)
int Length;
int err;

if (!PyArg_ParseTuple(args, F_HANDLE "O", &ConnectSocket, &AddressObj)) {

if (!_PyArg_ParseStack(args, nargs, F_HANDLE "O!:WSAConnect",
&ConnectSocket, &PyTuple_Type, &AddressObj)) {
return NULL;
}

Expand Down Expand Up @@ -1584,7 +1586,7 @@ PyDoc_STRVAR(
"Start overlapped sendto over a connectionless (UDP) socket");

static PyObject *
Overlapped_WSASendTo(OverlappedObject *self, PyObject *args)
Overlapped_WSASendTo(OverlappedObject *self, PyObject *args, Py_ssize_t nargs)
{
HANDLE handle;
PyObject *bufobj;
Expand All @@ -1598,8 +1600,8 @@ Overlapped_WSASendTo(OverlappedObject *self, PyObject *args)
int ret;
DWORD err;

if (!PyArg_ParseTuple(args, F_HANDLE "O" F_DWORD "O",
&handle, &bufobj, &flags, &AddressObj))
if (!_PyArg_ParseStack(args, nargs, F_HANDLE "OkO!:WSASendTo",
&handle, &bufobj, &flags, &PyTuple_Type, &AddressObj))
{
return NULL;
}
Expand Down Expand Up @@ -1752,7 +1754,7 @@ static PyMethodDef Overlapped_methods[] = {
{"WSARecvFrom", (PyCFunction) Overlapped_WSARecvFrom,
METH_VARARGS, Overlapped_WSARecvFrom_doc },
{"WSASendTo", (PyCFunction) Overlapped_WSASendTo,
METH_VARARGS, Overlapped_WSASendTo_doc },
METH_FASTCALL, Overlapped_WSASendTo_doc },
{NULL}
};

Expand Down Expand Up @@ -1841,7 +1843,7 @@ static PyMethodDef overlapped_functions[] = {
{"ConnectPipe", overlapped_ConnectPipe,
METH_VARARGS, ConnectPipe_doc},
{"WSAConnect", overlapped_WSAConnect,
METH_VARARGS, WSAConnect_doc},
METH_FASTCALL, WSAConnect_doc},
{NULL}
};

Expand Down
Loading