Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[3.11] gh-90953: Don't use deprecated AST nodes in clinic.py (GH-104322) #140856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ambv merged 1 commit into from
Oct 31, 2025
+3 −9
Merged

[3.11] gh-90953: Don't use deprecated AST nodes in clinic.py (GH-104322) #140856

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
gh-90953: Don't use deprecated AST nodes in clinic.py (GH-104322) 
(cherry picked from commit fe694a6)

Co-authored-by: Alex Waygood <[email protected]>
  • Loading branch information
@AlexWaygood @miss-islington
AlexWaygood authored and miss-islington committed Oct 31, 2025
commit 1e8f2e7b9060d743f6ef0ba7b3bcee426832992d
12 changes: 3 additions & 9 deletions Tools/clinic/clinic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4664,10 +4664,8 @@ def bad_node(self, node):
c_default = "NULL"
elif (isinstance(expr, ast.BinOp) or
(isinstance(expr, ast.UnaryOp) and
not (isinstance(expr.operand, ast.Num) or
(hasattr(ast, 'Constant') and
isinstance(expr.operand, ast.Constant) and
type(expr.operand.value) in (int, float, complex)))
not (isinstance(expr.operand, ast.Constant) and
type(expr.operand.value) in {int, float, complex})
)):
c_default = kwargs.get("c_default")
if not (isinstance(c_default, str) and c_default):
Expand Down Expand Up @@ -4769,14 +4767,10 @@ def bad_node(self, node):
self.function.parameters[key] = p

def parse_converter(self, annotation):
if (hasattr(ast, 'Constant') and
isinstance(annotation, ast.Constant) and
if (isinstance(annotation, ast.Constant) and
type(annotation.value) is str):
return annotation.value, True, {}

if isinstance(annotation, ast.Str):
return annotation.s, True, {}

if isinstance(annotation, ast.Name):
return annotation.id, False, {}

Expand Down
Loading