Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-139103: fix free-threading dataclass.__init__ perf issue #141596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
colesbury merged 9 commits into from
Nov 19, 2025
Merged

gh-139103: fix free-threading dataclass.__init__ perf issue #141596

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
fbda041
make lock with fine-grianed
LindaSummer Nov 15, 2025
273d2af
add benchmark script
LindaSummer Nov 15, 2025
724897b
add news entry.
LindaSummer Nov 15, 2025
e915039
fix for pre-commit.
LindaSummer Nov 15, 2025
65c695f
fix news for docs check.
LindaSummer Nov 15, 2025
aaaec25
update news entry
LindaSummer Nov 16, 2025
c02223e
remove redundant lock
LindaSummer Nov 17, 2025
34d4ffa
Format if statement and add comment
colesbury Nov 18, 2025
3846637
Merge branch 'main' into fix/dataclass-perf
LindaSummer Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix for pre-commit.
  • Loading branch information
@LindaSummer
LindaSummer committed Nov 16, 2025
commit e91503918074d5a2f2a8b9578bc64002205f89f6
2 changes: 1 addition & 1 deletion Objects/typeobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6585,7 +6585,7 @@ type_setattro(PyObject *self, PyObject *name, PyObject *value)
}
}


Comment thread
LindaSummer marked this conversation as resolved.
Outdated
BEGIN_TYPE_DICT_LOCK(dict);
res = type_update_dict(type, (PyDictObject *)dict, name, value, &old_value);
assert(_PyType_CheckConsistency(type));
Expand Down
2 changes: 1 addition & 1 deletion Tools/ftscalingbench/ftscalingbench.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ def method_caller():
obj = MyClass()
for i in range(1000 * WORK_SCALE):
mc(obj)

@dataclass
class MyDataClass:
x: int
Expand Down