Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-141570: can_colorize: Expect fileno() to raise OSError, as documented #141716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 7 commits into from
Nov 19, 2025
Merged

gh-141570: can_colorize: Expect fileno() to raise OSError, as documented #141716

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
49a5c57
can_colorize: Expect fileno() to raise OSError, as documented
hroncok Nov 18, 2025
ae077f0
fixup! can_colorize: Expect fileno() to raise OSError, as documented
hroncok Nov 18, 2025
1e91ce4
Update Misc/NEWS.d/next/Library/2025-11-18-14-39-31.gh-issue-141570.q…
hroncok Nov 19, 2025
731f2e3
Update Lib/test/test__colorize.py
hroncok Nov 19, 2025
96620c9
fixup! Update Misc/NEWS.d/next/Library/2025-11-18-14-39-31.gh-issue-1…
hroncok Nov 19, 2025
a2c1259
fixup! Update Misc/NEWS.d/next/Library/2025-11-18-14-39-31.gh-issue-1…
hroncok Nov 19, 2025
7f23184
Update Misc/NEWS.d/next/Library/2025-11-18-14-39-31.gh-issue-141570.q…
hroncok Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update Lib/test/test__colorize.py
  • Loading branch information
@hroncok
hroncok authored Nov 19, 2025
commit 731f2e337b9a6bc7696f190f2f9a316d7b11a0de
2 changes: 1 addition & 1 deletion Lib/test/test__colorize.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ def test_colorized_detection_checks_for_file(self):

# The documentation for file.fileno says:
# > An OSError is raised if the IO object does not use a file descriptor.
# See https://github.com/python/cpython/issues/141570
# gh-141570: Check OSError is caught and handled
with unittest.mock.patch("os.isatty", side_effect=ZeroDivisionError):
Comment thread
hroncok marked this conversation as resolved.
file = unittest.mock.MagicMock()
file.fileno.side_effect = OSError
Expand Down
Loading