Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-142029: Raise ValueError instead of crashing on empty name given to create_builtin() #142033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kumaraditya303 merged 9 commits into from
Dec 10, 2025
Merged

gh-142029: Raise ValueError instead of crashing on empty name given to create_builtin() #142033

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ddcf7e4
Check that `name` is non-empty in `_imp.create_builtin()`
dr-carlos Nov 28, 2025
901b039
Edit NEWS entry
dr-carlos Nov 28, 2025
784c232
Don't use `:func:` in NEWS for undocumented function
dr-carlos Nov 28, 2025
5102f3d
Update function name in NEWS entry
dr-carlos Nov 28, 2025
0350177
Add simple tests for `create_builtin()`
dr-carlos Nov 28, 2025
5d9aa6a
Update formatting in `test_create_builtin()`
dr-carlos Dec 2, 2025
81185df
Raise `ValueError` instead of `TypeError` for empty names
dr-carlos Dec 2, 2025
2165cce
Update NEWS entry
dr-carlos Dec 2, 2025
705b473
Update formatting in `import.c`
dr-carlos Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions Lib/test/test_import/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1253,6 +1253,28 @@ class Spec2:
origin = "a\x00b"
_imp.create_dynamic(Spec2())

def test_create_builtin(self):
class Spec:
name = None
spec = Spec()

with self.assertRaisesRegex(
TypeError,
'name must be string, not NoneType'
):
Comment thread
dr-carlos marked this conversation as resolved.
Outdated
_imp.create_builtin(spec)

class Spec:
name = ""
spec = Spec()
Comment thread
dr-carlos marked this conversation as resolved.
Outdated

# gh-142029
with self.assertRaisesRegex(
TypeError,
'name must not be empty'
):
Comment thread
dr-carlos marked this conversation as resolved.
Outdated
_imp.create_builtin(spec)

def test_filter_syntax_warnings_by_module(self):
module_re = r'test\.test_import\.data\.syntax_warnings\z'
unload('test.test_import.data.syntax_warnings')
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Core_and_Builtins/2025-11-28-16-45-07.gh-issue-142029.JuXiKu.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Raise :exc:`TypeError` instead of crashing when empty string is used as a
name in ``_imp.create_builtin()``.
7 changes: 7 additions & 0 deletions Python/import.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4420,6 +4420,13 @@ _imp_create_builtin(PyObject *module, PyObject *spec)
return NULL;
}

if (PyUnicode_GetLength(name) == 0) {
PyErr_Format(PyExc_TypeError,
Comment thread
dr-carlos marked this conversation as resolved.
Outdated
"name must not be empty");
Py_DECREF(name);
return NULL;
}

PyObject *mod = create_builtin(tstate, name, spec, NULL);
Py_DECREF(name);
return mod;
Expand Down
Loading